From ea7052ce644f255f55a5de91b88e9131044d50c7 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+ktf@users.noreply.github.com> Date: Fri, 16 Jan 2026 14:07:29 +0100 Subject: [PATCH] DPL: keep code checker happy The code checker complains about the unique_ptr going out of scope. However this is a false positive because such unique_ptr has a custom deletion policy to mimick the behavior of an observer_ptr. In order to keep the code checker happy, we use release, so that the bare pointer is returned without any complain. Given the custom deleter, the semantic is actually the same. --- Framework/Core/include/Framework/AnalysisManagers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Framework/Core/include/Framework/AnalysisManagers.h b/Framework/Core/include/Framework/AnalysisManagers.h index 5112e3659f4aa..fd41a079c6570 100644 --- a/Framework/Core/include/Framework/AnalysisManagers.h +++ b/Framework/Core/include/Framework/AnalysisManagers.h @@ -170,7 +170,7 @@ bool newDataframeCondition(InputRecord&, C&) template bool newDataframeCondition(InputRecord& record, C& condition) { - condition.instance = (typename C::type*)record.get(condition.path).get(); + condition.instance = (typename C::type*)record.get(condition.path).release(); return true; }