Closing inventory with a shift-clicked clickable adds the item your inventory

[ukulelelesheep]

Clickable close = new Clickable(icon) {
	@Override
	public void clicked(Player p) {
		p.closeInventory();
	}
};

Shift clicking adds icon to your inventory. If any other inventory is opened, then the item gets removed. If the item is dropped and picked back up, then the item is not removed, allowing a player to get an infinite amount of the item.

The issue is also present if clickableInventory.forceCloseInventory(p) is used instead of p.closeInventory()

The issue is resolved if closing the inventory is in a bukkit runnable that is run 1 tick later. Some sort of error thrown if an inventory is tried to be closed inside a clickable and a clickableIventory.closeLater(int tick) method or something like that would be a sufficient work around. Or maybe there is a fault elsewhere that is causing this.

[ProgrammerDan]

Very interesting. Inventory controls are a constant source of issues, in addition to being somewhat difficult to work with in the first place :D

…

On Tue, Nov 19, 2019 at 11:06 AM ukulelelesheep ***@***.***> wrote: Clickable close = new Clickable(icon) { @OverRide public void clicked(Player p) { p.closeInventory(); } }; Shift clicking adds icon to your inventory. If any other inventory is opened, then the item gets removed. If the item is dropped and picked back up, then the item is *not* removed, allowing a player to get an infinite amount of the item. The issue is also present if clickableInventory.forceCloseInventory(p) is used instead of p.closeInventory() The issue is resolved if closing the inventory is in a bukkit runnable that is run 1 tick later. Some sort of error thrown if an inventory is tried to be closed inside a clickable and a clickableIventory.closeLater(int tick) method or something like that would be a sufficient work around. Or maybe there is a fault elsewhere that is causing this. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#30?email_source=notifications&email_token=AADD5DW2QLTMWN6SSXC2GFLQUQFG7A5CNFSM4JPFT62KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2MPSIA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADD5DWR4LORLYDCWOYMGD3QUQFG7ANCNFSM4JPFT62A> .