Would you accept to migrate from octonode?

[RomainLanz]

Hey! 👋

The library octonode installs bluebird and request packages.

Since request is deprecated, it triggers a warning every time we install it.
It is also really heavy.

I believe bluebird is not useful anymore since any JavaScript runtimes support Promises.

GitHub made a library to request their REST or their GraphQL endpoint.

I propose that we switch to one of those libraries instead of relying on octonode.

[JakeChampion]

Hey! 👋

The library octonode installs bluebird and request packages.

Since request is deprecated, it triggers a warning every time we install it.
It is also really heavy.

I believe bluebird is not useful anymore since any JavaScript runtimes support Promises.

GitHub made a library to request their REST or their GraphQL endpoint.

I propose that we switch to one of those libraries instead of relying on octonode.

Sounds good with me 👍

[RomainLanz]

Cool! Would you prefer to use the GraphQL or REST endpoint?

[JakeChampion]

Cool! Would you prefer to use the GraphQL or REST endpoint?

@octokit/rest is preferred as we use it in other projects already

[RomainLanz]

It seems that tests are deeply linked to the implementation.
So I'll also need to rewrite all of those.

What do you think if we use this opportunity to write E2E tests that will verify that the code is working instead of using mocks everywhere (which is very dangerous since it doesn't test anything and can give wrong confidence about your code)?

[JakeChampion]

It seems that tests are deeply linked to the implementation.
So I'll also need to rewrite all of those.

What do you think if we use this opportunity to write E2E tests that will verify that the code is working instead of using mocks everywhere (which is very dangerous since it doesn't test anything and can give wrong confidence about your code)?

I'm happy with end-to-end tests, sounds like a good idea to have them 👍