From 77a5c8f183222b809654f26668ba54f918ee6a39 Mon Sep 17 00:00:00 2001 From: Aditya Alif Nugraha Date: Tue, 29 Apr 2025 11:26:28 +0200 Subject: [PATCH 1/2] Fix failing tests in query threads --- .../tests/async_chat/test_query_threads.py | 19 +++++++++---------- stream_chat/tests/test_query_threads.py | 17 ++++++++--------- 2 files changed, 17 insertions(+), 19 deletions(-) diff --git a/stream_chat/tests/async_chat/test_query_threads.py b/stream_chat/tests/async_chat/test_query_threads.py index c4a6bbb..564d991 100644 --- a/stream_chat/tests/async_chat/test_query_threads.py +++ b/stream_chat/tests/async_chat/test_query_threads.py @@ -22,7 +22,7 @@ async def test_query_threads( ) # Query threads with filter and sort - filter_conditions = {"parent_id": parent_message["message"]["id"]} + filter_conditions = {"parent_message_id": parent_message["message"]["id"]} sort_conditions = [{"field": "created_at", "direction": -1}] response = await client.query_threads( @@ -43,23 +43,22 @@ async def test_query_threads( async def test_query_threads_with_options( self, client: StreamChatAsync, channel, random_user: Dict ): - # Create a thread with multiple messages - parent_message = await channel.send_message( - {"text": "Parent message"}, random_user["id"] - ) - thread_messages = [] + for i in range(3): - msg = await channel.send_message( + parent_msg = await channel.send_message( + {"text": f"Parent message {i}"}, random_user["id"] + ) + + thread_msg = await channel.send_message( { "text": f"Thread message {i}", - "parent_id": parent_message["message"]["id"], + "parent_id": parent_msg["message"]["id"], }, random_user["id"], ) - thread_messages.append(msg) # Query threads with limit and offset - filter_conditions = {"parent_id": parent_message["message"]["id"]} + filter_conditions = {"channel_cid": channel.cid} sort_conditions = [{"field": "created_at", "direction": -1}] response = await client.query_threads( diff --git a/stream_chat/tests/test_query_threads.py b/stream_chat/tests/test_query_threads.py index 1bdd543..cac5515 100644 --- a/stream_chat/tests/test_query_threads.py +++ b/stream_chat/tests/test_query_threads.py @@ -17,7 +17,7 @@ def test_query_threads(self, client: StreamChat, channel, random_user: Dict): random_user["id"], ) - filter_conditions = {"parent_id": parent_message["message"]["id"]} + filter_conditions = {"parent_message_id": parent_message["message"]["id"]} sort_conditions = [{"field": "created_at", "direction": -1}] response = client.query_threads( @@ -36,21 +36,20 @@ def test_query_threads(self, client: StreamChat, channel, random_user: Dict): def test_query_threads_with_options( self, client: StreamChat, channel, random_user: Dict ): - parent_message = channel.send_message( - {"text": "Parent message"}, random_user["id"] - ) - thread_messages = [] for i in range(3): - msg = channel.send_message( + parent_msg = channel.send_message( + {"text": f"Parent message {i}"}, random_user["id"] + ) + + thread_msg = channel.send_message( { "text": f"Thread message {i}", - "parent_id": parent_message["message"]["id"], + "parent_id": parent_msg["message"]["id"], }, random_user["id"], ) - thread_messages.append(msg) - filter_conditions = {"parent_id": parent_message["message"]["id"]} + filter_conditions = {"channel_cid": channel.cid} sort_conditions = [{"field": "created_at", "direction": -1}] response = client.query_threads( From 5238ef415db7650c300575cde9cad1894ae91d64 Mon Sep 17 00:00:00 2001 From: Aditya Alif Nugraha Date: Tue, 29 Apr 2025 11:28:37 +0200 Subject: [PATCH 2/2] Fix lint --- stream_chat/tests/async_chat/test_query_threads.py | 2 +- stream_chat/tests/test_query_threads.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/stream_chat/tests/async_chat/test_query_threads.py b/stream_chat/tests/async_chat/test_query_threads.py index 564d991..28f1612 100644 --- a/stream_chat/tests/async_chat/test_query_threads.py +++ b/stream_chat/tests/async_chat/test_query_threads.py @@ -49,7 +49,7 @@ async def test_query_threads_with_options( {"text": f"Parent message {i}"}, random_user["id"] ) - thread_msg = await channel.send_message( + await channel.send_message( { "text": f"Thread message {i}", "parent_id": parent_msg["message"]["id"], diff --git a/stream_chat/tests/test_query_threads.py b/stream_chat/tests/test_query_threads.py index cac5515..d5b4206 100644 --- a/stream_chat/tests/test_query_threads.py +++ b/stream_chat/tests/test_query_threads.py @@ -41,7 +41,7 @@ def test_query_threads_with_options( {"text": f"Parent message {i}"}, random_user["id"] ) - thread_msg = channel.send_message( + channel.send_message( { "text": f"Thread message {i}", "parent_id": parent_msg["message"]["id"],