From f66c62881e532585b10c47cfdaccf4dc9c3926be Mon Sep 17 00:00:00 2001 From: David Kohl Date: Fri, 16 Jan 2026 14:06:59 -0500 Subject: [PATCH] feat(daemonset): functionality for user defined labels Signed-off-by: David Kohl --- .github/workflows/lint-test.yaml | 4 ++-- charts/core-dump-handler/templates/daemonset.yaml | 3 +++ charts/core-dump-handler/values.schema.json | 8 +++++++- charts/core-dump-handler/values.yaml | 1 + 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index b0e8e7e..bf12b0e 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -21,7 +21,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v2 with: - python-version: 3.7 + python-version: 3.14.2 - name: Set up chart-testing uses: helm/chart-testing-action@v2.1.0 @@ -42,4 +42,4 @@ jobs: # if: steps.list-changed.outputs.changed == 'true' # - name: Run chart-testing (install) - # run: ct install --config ct.yaml \ No newline at end of file + # run: ct install --config ct.yaml diff --git a/charts/core-dump-handler/templates/daemonset.yaml b/charts/core-dump-handler/templates/daemonset.yaml index f61f473..cf94c85 100644 --- a/charts/core-dump-handler/templates/daemonset.yaml +++ b/charts/core-dump-handler/templates/daemonset.yaml @@ -14,6 +14,9 @@ spec: metadata: labels: name: {{ .Values.daemonset.label }} + {{- with .Values.daemonset.labels }} + {{- toYaml . | nindent 8 }} + {{- end }} annotations: kubectl.kubernetes.io/default-container: "coredump-container" {{- with .Values.daemonset.podAnnotations }} diff --git a/charts/core-dump-handler/values.schema.json b/charts/core-dump-handler/values.schema.json index 0cac93d..697ae33 100644 --- a/charts/core-dump-handler/values.schema.json +++ b/charts/core-dump-handler/values.schema.json @@ -206,6 +206,12 @@ "name": { "type": "string" }, + "labels": { + "type": "object", + "additionalProperties": { + "type": "string" + } + }, "label": { "type": "string" }, @@ -352,4 +358,4 @@ "title": "ServiceAccount" } } -} \ No newline at end of file +} diff --git a/charts/core-dump-handler/values.yaml b/charts/core-dump-handler/values.yaml index 05f8213..7081ed2 100644 --- a/charts/core-dump-handler/values.yaml +++ b/charts/core-dump-handler/values.yaml @@ -37,6 +37,7 @@ daemonset: podAnnotations: {} name: "core-dump-handler" label: "core-dump-ds" + labels: {} hostDirectory: "/var/mnt/core-dump-handler" coreDirectory: "/var/mnt/core-dump-handler/cores" eventDirectory: "/var/mnt/core-dump-handler/events"