From bdbcacc0d6ce2d053ef37fe9dd43c3a54f9e70f2 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 23 Oct 2022 18:02:27 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- docker/restore_docker_volume_backup.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/docker/restore_docker_volume_backup.py b/docker/restore_docker_volume_backup.py index cfe1794..2d83509 100644 --- a/docker/restore_docker_volume_backup.py +++ b/docker/restore_docker_volume_backup.py @@ -65,7 +65,26 @@ def extract_backup_to_vol(list_backup_volume, dict_volume_list, dict_list_arhive print('Extcract volume {0}'.format(vol)) tar_file = '{0}/{1}'.format(dir, dict_list_arhive.get(vol)) with tarfile.open(tar_file, 'r') as tar: - tar.extractall(path=dir_mount) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=dir_mount) if __name__ == '__main__':