From 211bde96c92081bf7628174cf870ed2bd082c451 Mon Sep 17 00:00:00 2001 From: lani_karrot Date: Wed, 21 Jan 2026 15:12:16 +0900 Subject: [PATCH 1/4] test: AoS Tuple Sketch cross language --- .../strings/AosSketchCrossLanguageTest.java | 98 +++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java diff --git a/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java b/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java new file mode 100644 index 000000000..509742c73 --- /dev/null +++ b/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.datasketches.tuple.strings; + +import static org.apache.datasketches.common.TestUtil.GENERATE_JAVA_FILES; +import static org.apache.datasketches.common.TestUtil.javaPath; +import static org.testng.Assert.assertEquals; +import static org.testng.Assert.assertFalse; + +import java.io.IOException; +import java.nio.file.Files; + +import org.apache.datasketches.common.ResizeFactor; +import org.testng.annotations.Test; + +/** + * Serialize binary sketches to be tested by other language code. + * Test deserialization of binary sketches serialized by other language code. + */ +public class AosSketchCrossLanguageTest { + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateBinariesForCompatibilityTestingOneString() throws IOException { + final int[] nArr = {0, 1, 10, 100, 1000, 10_000, 100_000, 1_000_000}; + for (int n : nArr) { + final ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); + for (int i = 0; i < n; i++) { + sk.update(new String[] {String.valueOf(i)}, new String[] {"value" + i}); + } + Files.newOutputStream(javaPath.resolve("aos_1_n" + n + "_java.sk")).write(sk.compact().toByteArray()); + } + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateBinariesForCompatibilityTestingThreeStrings() throws IOException { + final int[] nArr = {0, 1, 10, 100, 1000, 10_000, 100_000, 1_000_000}; + for (int n : nArr) { + final ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); + for (int i = 0; i < n; i++) { + sk.update(new String[] {String.valueOf(i)}, new String[] {"a" + i, "b" + i, "c" + i}); + } + Files.newOutputStream(javaPath.resolve("aos_3_n" + n + "_java.sk")).write(sk.compact().toByteArray()); + } + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateBinariesForCompatibilityTestingNonEmptyNoEntries() throws IOException { + final ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(12, + ResizeFactor.X8, 0.01f); + sk.update(new String[] {"key1"}, new String[] {"value1"}); + assertFalse(sk.isEmpty()); + assertEquals(sk.getRetainedEntries(), 0); + Files.newOutputStream(javaPath.resolve("aos_1_non_empty_no_entries_java.sk")).write(sk.compact().toByteArray()); + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateBinariesForCompatibilityTestingMultiKeyStrings() throws IOException { + final int[] nArr = {0, 1, 10, 100, 1000, 10_000}; + for (int n : nArr) { + final ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); + for (int i = 0; i < n; i++) { + sk.update(new String[] {"key" + i, "subkey" + (i % 10)}, new String[] {"value" + i}); + } + Files.newOutputStream(javaPath.resolve("aos_multikey_n" + n + "_java.sk")).write(sk.compact().toByteArray()); + } + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateBinariesForCompatibilityTestingUnicodeStrings() throws IOException { + final ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); + + sk.update(new String[]{"키", "열쇠"}, new String[]{"밸류", "값"}); + sk.update(new String[]{"🔑", "🗝️"}, new String[]{"📦", "🎁"}); + sk.update(new String[]{"ключ1", "ключ2"}, new String[]{"ценить1", "ценить2"}); + + assertFalse(sk.isEmpty()); + assertEquals(sk.getRetainedEntries(), 3); + + Files.newOutputStream(javaPath.resolve("aos_unicode_java.sk")).write(sk.compact().toByteArray()); + } +} From 2f607c89a584a1d476b9cd597def14eff3396a57 Mon Sep 17 00:00:00 2001 From: lani_karrot Date: Wed, 21 Jan 2026 15:14:34 +0900 Subject: [PATCH 2/4] test: AoS Tuple Sketch cross language cases --- .../strings/AosSketchCrossLanguageTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java b/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java index 509742c73..baf89304e 100644 --- a/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java +++ b/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java @@ -38,9 +38,9 @@ public class AosSketchCrossLanguageTest { @Test(groups = {GENERATE_JAVA_FILES}) public void generateBinariesForCompatibilityTestingOneString() throws IOException { - final int[] nArr = {0, 1, 10, 100, 1000, 10_000, 100_000, 1_000_000}; + int[] nArr = {0, 1, 10, 100, 1000, 10_000, 100_000, 1_000_000}; for (int n : nArr) { - final ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); + ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); for (int i = 0; i < n; i++) { sk.update(new String[] {String.valueOf(i)}, new String[] {"value" + i}); } @@ -50,9 +50,9 @@ public void generateBinariesForCompatibilityTestingOneString() throws IOExceptio @Test(groups = {GENERATE_JAVA_FILES}) public void generateBinariesForCompatibilityTestingThreeStrings() throws IOException { - final int[] nArr = {0, 1, 10, 100, 1000, 10_000, 100_000, 1_000_000}; + int[] nArr = {0, 1, 10, 100, 1000, 10_000, 100_000, 1_000_000}; for (int n : nArr) { - final ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); + ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); for (int i = 0; i < n; i++) { sk.update(new String[] {String.valueOf(i)}, new String[] {"a" + i, "b" + i, "c" + i}); } @@ -62,7 +62,7 @@ public void generateBinariesForCompatibilityTestingThreeStrings() throws IOExcep @Test(groups = {GENERATE_JAVA_FILES}) public void generateBinariesForCompatibilityTestingNonEmptyNoEntries() throws IOException { - final ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(12, + ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(12, ResizeFactor.X8, 0.01f); sk.update(new String[] {"key1"}, new String[] {"value1"}); assertFalse(sk.isEmpty()); @@ -72,9 +72,9 @@ public void generateBinariesForCompatibilityTestingNonEmptyNoEntries() throws IO @Test(groups = {GENERATE_JAVA_FILES}) public void generateBinariesForCompatibilityTestingMultiKeyStrings() throws IOException { - final int[] nArr = {0, 1, 10, 100, 1000, 10_000}; + int[] nArr = {0, 1, 10, 100, 1000, 10_000}; for (int n : nArr) { - final ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); + ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); for (int i = 0; i < n; i++) { sk.update(new String[] {"key" + i, "subkey" + (i % 10)}, new String[] {"value" + i}); } @@ -84,7 +84,7 @@ public void generateBinariesForCompatibilityTestingMultiKeyStrings() throws IOEx @Test(groups = {GENERATE_JAVA_FILES}) public void generateBinariesForCompatibilityTestingUnicodeStrings() throws IOException { - final ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); + ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); sk.update(new String[]{"키", "열쇠"}, new String[]{"밸류", "값"}); sk.update(new String[]{"🔑", "🗝️"}, new String[]{"📦", "🎁"}); From 0df6a6819051e377c9f1b699d6b464eac71a4b61 Mon Sep 17 00:00:00 2001 From: lani_karrot Date: Wed, 21 Jan 2026 15:33:11 +0900 Subject: [PATCH 3/4] test: add empty string cases --- .../tuple/strings/AosSketchCrossLanguageTest.java | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java b/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java index baf89304e..25271e255 100644 --- a/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java +++ b/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java @@ -95,4 +95,18 @@ public void generateBinariesForCompatibilityTestingUnicodeStrings() throws IOExc Files.newOutputStream(javaPath.resolve("aos_unicode_java.sk")).write(sk.compact().toByteArray()); } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateBinariesForCompatibilityTestingEmptyStrings() throws IOException { + ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); + + sk.update(new String[]{""}, new String[]{"empty_key_value"}); + sk.update(new String[]{"empty_value_key"}, new String[]{""}); + sk.update(new String[]{"", ""}, new String[]{"", ""}); + + assertFalse(sk.isEmpty()); + assertEquals(sk.getRetainedEntries(), 3); + + Files.newOutputStream(javaPath.resolve("aos_empty_strings_java.sk")).write(sk.compact().toByteArray()); + } } From 70d9dc7b6ea589bc27106fb927cde1e4acba058c Mon Sep 17 00:00:00 2001 From: proost Date: Thu, 22 Jan 2026 01:07:15 +0900 Subject: [PATCH 4/4] test: unify n --- .../datasketches/tuple/strings/AosSketchCrossLanguageTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java b/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java index 25271e255..dd425abfa 100644 --- a/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java +++ b/src/test/java/org/apache/datasketches/tuple/strings/AosSketchCrossLanguageTest.java @@ -72,7 +72,7 @@ public void generateBinariesForCompatibilityTestingNonEmptyNoEntries() throws IO @Test(groups = {GENERATE_JAVA_FILES}) public void generateBinariesForCompatibilityTestingMultiKeyStrings() throws IOException { - int[] nArr = {0, 1, 10, 100, 1000, 10_000}; + int[] nArr = {0, 1, 10, 100, 1000, 10_000, 100_000, 1_000_000}; for (int n : nArr) { ArrayOfStringsTupleSketch sk = new ArrayOfStringsTupleSketch(); for (int i = 0; i < n; i++) {