From 2e567b23a4bcce13e32caa3c99d8d38943236408 Mon Sep 17 00:00:00 2001 From: Jin Seop Kim Date: Tue, 27 Jan 2026 13:53:39 -0500 Subject: [PATCH 1/2] fix: correct FirestoreAdminClient source link in documentation The FirestoreAdminClient source code resides in the `google-cloud-firestore-admin` directory, which differs from the artifact ID (`google-cloud-firestore`). This mismatch causes the generated GitHub source links in the documentation to be broken. This change adds `library_path_overrides` to `.repo-metadata.json` to explicitly map `FirestoreAdminClient` to the correct source directory. Fixes: b/442875200 --- .repo-metadata.json | 5 ++++- owlbot.py | 22 ++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/.repo-metadata.json b/.repo-metadata.json index 96676f572..0bf1bcd9a 100644 --- a/.repo-metadata.json +++ b/.repo-metadata.json @@ -10,6 +10,9 @@ "repo": "googleapis/java-firestore", "repo_short": "java-firestore", "distribution_name": "com.google.cloud:google-cloud-firestore", + "library_path_overrides": { + "FirestoreAdminClient": "google-cloud-firestore-admin" + }, "api_id": "firestore.googleapis.com", "library_type": "GAPIC_COMBO", "requires_billing": true, @@ -17,4 +20,4 @@ "excluded_poms": "google-cloud-firestore,google-cloud-firestore-bom", "issue_tracker": "https://issuetracker.google.com/savedsearches/5337669", "recommended_package": "com.google.cloud.firestore" -} \ No newline at end of file +} diff --git a/owlbot.py b/owlbot.py index f43e54969..5bff3ed98 100644 --- a/owlbot.py +++ b/owlbot.py @@ -14,6 +14,7 @@ """This script is used to synthesize generated parts of this library.""" +import json import synthtool as s import synthtool.gcp as gcp import synthtool.languages.java as java @@ -97,3 +98,24 @@ '.github/workflows/samples.yaml', 'renovate.json' ]) + +# Fix for b/442875200: Inject library_path_overrides for FirestoreAdminClient +# This ensures the doclet links to the correct source directory (google-cloud-firestore-admin) +# instead of the default artifactId (google-cloud-firestore). +metadata_path = ".repo-metadata.json" +try: + with open(metadata_path, "r") as f: + metadata = json.load(f) + + # Add the override map if it doesn't exist or update it + if "library_path_overrides" not in metadata: + metadata["library_path_overrides"] = {} + + metadata["library_path_overrides"]["FirestoreAdminClient"] = "google-cloud-firestore-admin" + + # Write the updated metadata back to the file + with open(metadata_path, "w") as f: + json.dump(metadata, f, indent=2) + f.write("\n") +except Exception as e: + print(f"Failed to update .repo-metadata.json: {e}") From ffe7f80decfcda397f5cabbc5ce2a0cf1f676ea2 Mon Sep 17 00:00:00 2001 From: cloud-java-bot Date: Wed, 28 Jan 2026 18:57:02 +0000 Subject: [PATCH 2/2] chore: generate libraries at Wed Jan 28 18:54:55 UTC 2026 --- .repo-metadata.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.repo-metadata.json b/.repo-metadata.json index 0bf1bcd9a..b95420bc8 100644 --- a/.repo-metadata.json +++ b/.repo-metadata.json @@ -10,14 +10,14 @@ "repo": "googleapis/java-firestore", "repo_short": "java-firestore", "distribution_name": "com.google.cloud:google-cloud-firestore", - "library_path_overrides": { - "FirestoreAdminClient": "google-cloud-firestore-admin" - }, "api_id": "firestore.googleapis.com", "library_type": "GAPIC_COMBO", "requires_billing": true, "codeowner_team": "@googleapis/api-firestore @googleapis/firestore-dpe", "excluded_poms": "google-cloud-firestore,google-cloud-firestore-bom", "issue_tracker": "https://issuetracker.google.com/savedsearches/5337669", - "recommended_package": "com.google.cloud.firestore" + "recommended_package": "com.google.cloud.firestore", + "library_path_overrides": { + "FirestoreAdminClient": "google-cloud-firestore-admin" + } }