From 7d65829411a36de10b35e67aeacd627a6966b1cd Mon Sep 17 00:00:00 2001 From: Sandro Ciervo Date: Wed, 14 May 2025 15:15:28 +0200 Subject: [PATCH 1/2] Do not throw exceptions that occur before the builder is built --- Neolution.DotNet.Console/DotNetConsoleBuilder.cs | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/Neolution.DotNet.Console/DotNetConsoleBuilder.cs b/Neolution.DotNet.Console/DotNetConsoleBuilder.cs index 442f4d0..ceea7b7 100644 --- a/Neolution.DotNet.Console/DotNetConsoleBuilder.cs +++ b/Neolution.DotNet.Console/DotNetConsoleBuilder.cs @@ -135,14 +135,22 @@ internal static DotNetConsoleBuilder CreateBuilderInternal(Assembly assembly, Ty .ToArray(); var parsedArguments = Parser.Default.ParseArguments(args, verbTypes); - var consoleBuilder = new DotNetConsoleBuilder(builder, parsedArguments, environment, configuration); - if (args.Length == 1 && string.Equals(args[0], "check-deps", StringComparison.OrdinalIgnoreCase)) { - consoleBuilder.checkDependencies = true; - return consoleBuilder; + try + { + return new DotNetConsoleBuilder(builder, parsedArguments, environment, configuration) + { + checkDependencies = true, + }; + } + catch (Exception) + { + // Only check service dependencies, which happens when the builder is built. All other exceptions are ignored. + } } + var consoleBuilder = new DotNetConsoleBuilder(builder, parsedArguments, environment, configuration); CheckStrictVerbMatching(args, verbTypes); return consoleBuilder; } From aa0b724cbbf072872a1ce3a852a9772cf59addd1 Mon Sep 17 00:00:00 2001 From: Sandro Ciervo Date: Wed, 14 May 2025 15:25:40 +0200 Subject: [PATCH 2/2] Add to changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b570625..bc88eee 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Changed + +- When using `check-deps`, do not throw exceptions that occur before the DotNetConsoleBuilder is built + ## [5.0.0] - 2025-01-27 ### Added