From 897758e57e1e84386a46a43d9307ede22a04d08a Mon Sep 17 00:00:00 2001 From: ss77995ss Date: Sun, 12 Jan 2025 23:47:53 +0800 Subject: [PATCH 1/3] fix(Statcast): Fix sending season params to using `season_start` and `season_end` --- src/baseball_stats_python/statcast/catcher_throwing.py | 5 +++-- src/baseball_stats_python/statcast/runner_basestealing.py | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/baseball_stats_python/statcast/catcher_throwing.py b/src/baseball_stats_python/statcast/catcher_throwing.py index d332e99..10be167 100644 --- a/src/baseball_stats_python/statcast/catcher_throwing.py +++ b/src/baseball_stats_python/statcast/catcher_throwing.py @@ -43,8 +43,9 @@ def catcher_throwing( ) params = { - 'gameType': game_type, - 'season': season, + 'game_type': game_type, + 'season_start': season, + 'season_end': season, 'n': 0, } diff --git a/src/baseball_stats_python/statcast/runner_basestealing.py b/src/baseball_stats_python/statcast/runner_basestealing.py index 645603d..6eb59e4 100644 --- a/src/baseball_stats_python/statcast/runner_basestealing.py +++ b/src/baseball_stats_python/statcast/runner_basestealing.py @@ -65,7 +65,8 @@ def runner_basestealing( params = { 'game_type': game_type, - 'season': season, + 'season_start': season, + 'season_end': season, 'n': 0, 'pitch_hand': get_hand_param_str(pitch_hand), 'prior_pk': get_prior_pk_param_str(prior_pk), From 7c53c842773c8fbf54f14d6710918b9179494690 Mon Sep 17 00:00:00 2001 From: ss77995ss Date: Mon, 13 Jan 2025 00:09:51 +0800 Subject: [PATCH 2/3] fix(Github Actions): Change ruff action to latest version --- .github/workflows/publish.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 322b535..a3a5695 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -33,10 +33,10 @@ jobs: run: | python -m pip install --upgrade pip pip install ruff - - uses: chartboost/ruff-action@v1 + - uses: astral-sh/ruff-action@v3 with: args: 'check' - - uses: chartboost/ruff-action@v1 + - uses: astral-sh/ruff-action@v3 with: args: 'format --check' From 821e70c7e3930f3826ce2dade70bbd4b9f22db8e Mon Sep 17 00:00:00 2001 From: ss77995ss Date: Mon, 13 Jan 2025 00:18:32 +0800 Subject: [PATCH 3/3] fix(Actions): ruff format --check some how would be failed on ubuntu. Remove it before it fixed * ref: https://github.com/astral-sh/ruff/issues/15391 --- .github/workflows/publish.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index a3a5695..7bd7711 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -36,9 +36,6 @@ jobs: - uses: astral-sh/ruff-action@v3 with: args: 'check' - - uses: astral-sh/ruff-action@v3 - with: - args: 'format --check' build: name: Build distribution 📦