feat: Optimization postLogsFilter

[0xbigapple]

What does this PR do?
Optimization postLogsFilter function, If the block result is already in memory, use it directly. Avoids re-querying the database for data just written.

Why are these changes required?

This PR has been tested by:

• Unit Tests
• Manual Testing

Follow up

Extra details

[github-actions]

📋 Review Summary

This pull request introduces a valuable performance optimization to the postLogsFilter method by checking for in-memory block results before querying the database. The logic is sound and improves efficiency.

🔍 General Feedback

• The core change is a good optimization that avoids unnecessary database lookups.
• A critical typo was found in a method call that will need to be fixed for the build to pass.

Once the typo is addressed, this change will be a solid improvement.

[github-actions]

🔴 There's a typo in the method name getTransactioninfoList. Based on Java conventions and likely protobuf generated code, it should be getTransactionInfoList with a capital 'I'. This will cause a compilation error.

Suggested change

	// Avoids re-querying the database for data just written.
	transactionInfoList = blockCapsule.getResult().getInstance().getTransactionInfoList();

[github-actions]

## 📋 Review Summary

This pull request introduces a valuable performance optimization to the postLogsFilter function. By checking for transaction information in memory before querying the database, it avoids unnecessary database operations, which should improve performance. The implementation is clear and correct.

🔍 General Feedback

• The change is well-contained and directly addresses the goal of the optimization.
• The use of a fallback mechanism ensures that the existing functionality is preserved if the in-memory data is not available.
• A minor suggestion was made to improve code cleanliness by removing a redundant comment.

Overall, this is a good improvement.

[github-actions]

🟡 The comment in the `else` block is redundant because the code is self-explanatory. Consider removing it to make the code cleaner.

Suggested change

	// Avoids re-querying the database for data just written.
	if (blockCapsule.getResult() != null) {
	transactionInfoList = blockCapsule.getResult().getInstance().getTransactioninfoList();
	} else {
	// Fallback to querying from DB if not available in memory.
	transactionInfoList = getTransactionInfoByBlockNum(blockNumber).getTransactionInfoList();
	}
	List<TransactionInfo> transactionInfoList;
	// Optimization: If the block result is already in memory, use it directly.
	// Avoids re-querying the database for data just written.
	if (blockCapsule.getResult() != null) {
	transactionInfoList = blockCapsule.getResult().getInstance().getTransactioninfoList();
	} else {
	transactionInfoList = getTransactionInfoByBlockNum(blockNumber).getTransactionInfoList();
	}

[github-actions]

📋 Review Summary

This pull request introduces a valuable optimization to the postLogsFilter method by caching transaction info in memory to reduce database queries. The implementation is clear and effective.

🔍 General Feedback

• The code change is well-implemented and includes explanatory comments.
• The logic for falling back to a database query is sound.
• A minor suggestion for improving variable scope has been noted in an inline comment.

[github-actions]

🟢 For better scoping, consider moving the declaration of blockNumber inside the following if block, as it is only used there.

[github-actions]

📋 Review Summary

The pull request introduces an optimization to avoid an unnecessary database query by using in-memory data when available. The change is logical and improves performance.

🔍 General Feedback

• The code is well-commented, explaining the purpose of the optimization. I've added a minor suggestion to improve readability and avoid redundant method calls.

[github-actions]

🟡 For better readability and to avoid multiple calls to getResult(), you can store the result of blockCapsule.getResult() in a local variable.

Suggested change

	// Optimization: If the block result is already in memory, use it directly.
	// Avoids re-querying the database for data just written.
	if (blockCapsule.getResult() != null) {
	transactionInfoList = blockCapsule.getResult().getInstance().getTransactioninfoList();
	} else {
	// Fallback to querying from DB if not available in memory.
	List<TransactionInfo> transactionInfoList;
	// Optimization: If the block result is already in memory, use it directly.
	// Avoids re-querying the database for data just written.
	var blockResult = blockCapsule.getResult();
	if (blockResult != null) {
	transactionInfoList = blockResult.getInstance().getTransactioninfoList();
	} else {
	// Fallback to querying from DB if not available in memory.
	transactionInfoList = getTransactionInfoByBlockNum(blockNumber).getTransactionInfoList();
	}