-
Notifications
You must be signed in to change notification settings - Fork 453
Tyagiva diagon upgrade #2976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tyagiva diagon upgrade #2976
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
You will need to update your PR description to pass the check. You could check other merged PRs. I think your change following with seed env instruction (link) should also work. If it isn't too much trouble, I’d recommend following this path for better consistency. Also cc @SurbhiJainUSC for this change. We usually need 2 approvals for the PR. |
| google-cloud-core>=2.5.0 | ||
| google-cloud-logging>=3.12.1 | ||
| google-cloud-mldiagnostics>=0.5.5 | ||
| google-cloud-mldiagnostics>=0.5.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow https://maxtext.readthedocs.io/en/latest/install_maxtext.html#update-maxtext-dependencies to update the dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how i started and its available in 1st commit. Unfortunately, setup has some issues and dependencies generated via seed was breaking the build so i reverted to just my dependency.
Description
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.