Bugfix/atr 939 dev px1098 code fix handle out and ref parameters #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d ref readonly modifiers in the signature
…iew delegates and rare view delegates with ref parameters
…oducing a replacement algorithm to add required ref modifiers to the generated doc ID for the method
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of ref and out parameters in PXOverride method validation and XML documentation generation. The changes ensure that view delegates can accept either all regular parameters or all ref parameters, and that XML documentation comments correctly include parameter modifiers (ref, out, in, ref readonly) when referencing base methods.
Changes:
- Fixed view delegate validation to allow either all regular parameters or all
refparameters - Corrected spelling of
CanBeOverriddenmethod name - Added logic to insert parameter modifiers in XML documentation comment IDs for methods with
ref/out/inparameters - Added comprehensive test coverage for PXOverride methods with
refandoutparameters
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| GraphSymbolUtils.cs | Updated view delegate validation to support methods with all ref parameters |
| IMethodSymbolExtensions.cs | Fixed spelling of CanBeOverridden method name |
| AcumaticaOverridesHelper.cs | Updated method call to use corrected CanBeOverridden spelling |
| PXOverrideRefAndOutParametersWithoutXmlComment_Expected.cs | Added expected test output for PXOverride methods with ref/out parameters |
| PXOverrideRefAndOutParametersWithoutXmlComment.cs | Added test case for PXOverride methods with ref/out parameters |
| PXOverrideWithoutXmlCommentTests.cs | Added test methods to verify ref/out parameter handling |
| PXOverrideAnalyzer.cs | Implemented logic to generate correct XML doc comment IDs with parameter modifiers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Acuminator/Acuminator.Analyzers/StaticAnalysis/PXOverride/PXOverrideAnalyzer.cs
Show resolved
Hide resolved
src/Acuminator/Acuminator.Analyzers/StaticAnalysis/PXOverride/PXOverrideAnalyzer.cs
Show resolved
Hide resolved
dropsonic
approved these changes
Jan 20, 2026
SENya1990
deleted the
bugfix/ATR-939-dev-PX1098-code-fix-handle-out-and-ref-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
ref/out/in/ref readonlyparameters by introducing a replacement algorithm to add required ref modifiers to the generated doc ID for the methodrefparametersref,out,in, andref readonlymodifiers in the signature