Skip to content

Allow set setDrawMarkerViews() with isDrawMarkersEnabled #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannesa2 merged 1 commit into from
Jan 14, 2026
Merged

Allow set setDrawMarkerViews() with isDrawMarkersEnabled #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/main/kotlin/info/appdev/chartexample/BarChartActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class BarChartActivity : DemoBase(), OnSeekBarChangeListener, OnChartValueSelect
binding.chart1.setOnChartValueSelectedListener(this)
binding.chart1.setRoundedBarRadius(50f)

binding.chart1.setDrawMarkerViews(true)
binding.chart1.isDrawBarShadow = false
binding.chart1.isDrawValueAboveBar = true

Expand Down
3 changes: 1 addition & 2 deletions chartLib/src/main/kotlin/info/appdev/charting/charts/Chart.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,6 @@ abstract class Chart<T : ChartData<out IDataSet<out Entry>>> : ViewGroup, IBaseP
* (use the setMarker(IMarker marker) method to specify a marker)
*/
var isDrawMarkersEnabled: Boolean = true
protected set

/**
* the view that represents the marker
Expand Down Expand Up @@ -984,7 +983,7 @@ abstract class Chart<T : ChartData<out IDataSet<out Entry>>> : ViewGroup, IBaseP
val isDrawMarkerViewsEnabled: Boolean
get() = this.isDrawMarkersEnabled

@Deprecated("Use 'isDrawMarkersEnabled' directly")
@Deprecated("Use 'isDrawMarkersEnabled' directly", ReplaceWith("isDrawMarkersEnabled = value"))
fun setDrawMarkerViews(value: Boolean) {
this.isDrawMarkersEnabled = value
}
Expand Down
Loading