Skip to content

UN-2273 add reviewerType to GET /campaigns/:cid/bugs response #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sinatragianpaolo wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

UN-2273 add reviewerType to GET /campaigns/:cid/bugs response #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0c71654
fix: clean up OpenAPI errors
sinatragianpaolo Jan 22, 2026
8f08681
fix: add missing peer dependencies in package-lock.json
sinatragianpaolo Jan 22, 2026
22a57ca
feat: add reviewerType field to operations schema and update OpenAPI …
sinatragianpaolo Jan 22, 2026
9d6d6ea
feat: add AI_REVIEWER_PROFILE_ID to .env.template
sinatragianpaolo Jan 22, 2026
0ff8e84
feat: add AI_REVIEWER_PROFILE_ID to configuration and deployment scripts
sinatragianpaolo Jan 22, 2026
f8fa7f3
feat: implement reviewerType logic in BugsRoute and update tests
sinatragianpaolo Jan 23, 2026
57f9f47
fix: restore missing peer property in package-lock.json entries
sinatragianpaolo Jan 23, 2026
f97a9a5
fix: remove unused fs import in media upload route
sinatragianpaolo Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .env.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,6 @@ SENTRY_ENVIRONMENT=local


CAMPAIGN_CREATION_WEBHOOK=https://webhook.site/11111111-1111-1111-1111-11111111111
STATUS_CHANGE_WEBHOOK=https://webhook.site/11111111-1111-1111-1111-11111111111
STATUS_CHANGE_WEBHOOK=https://webhook.site/11111111-1111-1111-1111-11111111111

AI_REVIEWER_PROFILE_ID=11111
1 change: 1 addition & 0 deletions deployment/after-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ services:
TESTER_LEADER_CPV2_EMAIL: '${TESTER_LEADER_CPV2_EMAIL}'
TASK_MEDIA_BUCKET: '${TASK_MEDIA_BUCKET}'
OPTIMIZED_TASK_MEDIA_BUCKET: '${OPTIMIZED_TASK_MEDIA_BUCKET}'
AI_REVIEWER_PROFILE_ID: '${AI_REVIEWER_PROFILE_ID}'
volumes:
- /var/docker/keys:/app/keys
logging:
Expand Down
2 changes: 2 additions & 0 deletions src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const config: {
name: string;
email: string;
};
aiReviewer: number;
} = {
port: process.env.PORT || "3000",
apiRoot: false,
Expand Down Expand Up @@ -77,6 +78,7 @@ const config: {
name: process.env.TESTER_LEADER_CPV2_NAME || "Unknown",
email: process.env.TESTER_LEADER_CPV2_EMAIL || "Unknown",
},
aiReviewer: Number(process.env.AI_REVIEWER_PROFILE_ID) || 0,
};

if (process.env.SSL_CHAIN && process.env.SSL_PRIVATE) {
Expand Down
138 changes: 102 additions & 36 deletions src/reference/openapi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2985,11 +2985,86 @@ paths:
size: 0
start: 0
total: 0
reviewer-types:
value:
items:
- created: string
duplication: father
id: 1
internalId: string
isFavourite: true
severity:
id: 0
name: string
status:
id: 0
name: string
tags:
- id: 0
name: string
tester:
id: 0
title: string
type:
id: 0
name: string
updated: string
- created: string
duplication: father
id: 2
internalId: string
isFavourite: true
reviewerType: ai
severity:
id: 0
name: string
status:
id: 0
name: string
tags:
- id: 0
name: string
tester:
id: 0
title: string
type:
id: 0
name: string
updated: string
- created: string
duplication: father
id: 3
internalId: string
isFavourite: true
reviewerType: human
severity:
id: 0
name: string
status:
id: 0
name: string
tags:
- id: 0
name: string
tester:
id: 0
title: string
type:
id: 0
name: string
updated: string
limit: 0
size: 0
start: 0
total: 3
schema:
allOf:
- properties:
- type: object
properties:
items:
type: array
items:
type: object
properties:
created:
type: string
Expand All @@ -3005,68 +3080,70 @@ paths:
type: string
isFavourite:
type: boolean
reviewerType:
type: string
enum:
- ai
- human
severity:
type: object
required:
- id
- name
properties:
id:
type: integer
name:
type: string
status:
type: object
required:
- id
- name
type: object
status:
properties:
id:
type: integer
name:
type: string
required:
- id
- name
type: object
tags:
type: array
items:
$ref: '#/components/schemas/BugTag'
type: array
tester:
type: object
required:
- id
properties:
id:
type: integer
required:
- id
type: object
title:
type: string
type:
type: object
required:
- id
- name
properties:
id:
type: integer
name:
type: string
required:
- id
- name
type: object
updated:
type: string
required:
- created
- duplication
- id
- title
- internalId
- status
- type
- isFavourite
- severity
- status
- tester
- duplication
- isFavourite
- created
- title
- type
- updated
type: object
type: array
required:
- items
type: object
- $ref: '#/components/schemas/PaginationData'
description: OK
'403':
Expand Down Expand Up @@ -6671,13 +6748,7 @@ paths:
summary: Get Human Resources for a campaign
tags: []
parameters:
- schema:
type: string
name: campaign
in: path
required: true
- $ref: '#/components/parameters/campaign'
description: Updates tokens_usage in campaign and updates the link between cp_id and agreementId
put:
summary: Your PUT endpoint
tags: []
Expand Down Expand Up @@ -12841,6 +12912,7 @@ paths:
- id: 0
name: Name
rate: 0
description: ''
'403':
$ref: '#/components/responses/Authentication'
'404':
Expand Down Expand Up @@ -13173,12 +13245,6 @@ paths:
schema:
type: object
properties: {}
'':
content:
application/json:
schema:
type: object
properties: {}
security:
- JWT: []
requestBody:
Expand Down
23 changes: 22 additions & 1 deletion src/routes/campaigns/campaignId/bugs/_get/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ import request from "supertest";
const yesterday = new Date(new Date().getTime() - 86400000).toISOString();
const tomorrow = new Date(new Date().getTime() + 86400000).toISOString();

// mock config to set aiReviewer to 100
jest.mock("@src/config", () => ({
__esModule: true,
default: {
...jest.requireActual("@src/config").default,
aiReviewer: 100,
},
}));

beforeAll(async () => {
await tryber.tables.WpAppqEvdProfile.do().insert({
id: 1,
Expand Down Expand Up @@ -70,7 +79,7 @@ beforeAll(async () => {
status_id: 1,
wp_user_id: 1,
profile_id: 1,
reviewer: 1,
reviewer: 100,
last_editor_id: 1,
severity_id: 1,
bug_replicability_id: 1,
Expand Down Expand Up @@ -227,4 +236,16 @@ describe("GET /campaigns/campaignId/bugs", () => {
expect(response.body.items[1]).toHaveProperty("tester", { id: 1 });
expect(response.body.items[2]).toHaveProperty("tester", { id: 1 });
});
// Should return a bug list with reviewerType foreach bug
it("Should return a bug list with reviewerType foreach bug", async () => {
const response = await request(app)
.get("/campaigns/1/bugs")
.set("Authorization", "Bearer admin");
expect(response.body).toHaveProperty("items");

expect(response.body.items).toHaveLength(3);
expect(response.body.items[0]).toHaveProperty("reviewerType", "ai");
expect(response.body.items[1]).toHaveProperty("reviewerType", "human");
expect(response.body.items[2]).toHaveProperty("reviewerType", "human");
});
});
7 changes: 7 additions & 0 deletions src/routes/campaigns/campaignId/bugs/_get/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,16 @@
import OpenapiError from "@src/features/OpenapiError";
import { tryber } from "@src/features/database";
import CampaignRoute from "@src/features/routes/CampaignRoute";
import config from "@src/config";

interface Tag {
id: number;
name: string;
}

type ReviewerType =
StoplightOperations["get-campaigns-cid-bugs"]["responses"]["200"]["content"]["application/json"]["items"][number]["reviewerType"];

export default class BugsRoute extends CampaignRoute<{
response: StoplightOperations["get-campaigns-cid-bugs"]["responses"]["200"]["content"]["application/json"];
parameters: StoplightOperations["get-campaigns-cid-bugs"]["parameters"]["path"];
Expand Down Expand Up @@ -133,6 +137,7 @@ export default class BugsRoute extends CampaignRoute<{
"is_duplicated",
"duplicated_of_id",
"is_favorite",
"reviewer",
tryber.raw("CAST(created AS CHAR) as created"),
tryber.raw("CAST(updated AS CHAR) as updated"),
tryber.ref("message").as("title"),
Expand Down Expand Up @@ -197,6 +202,7 @@ export default class BugsRoute extends CampaignRoute<{
id: bug.bug_type_id,
name: bug.type,
},
reviewerType: bug.reviewer === config.aiReviewer ? "ai" : "human",
}));
}

Expand Down Expand Up @@ -277,6 +283,7 @@ export default class BugsRoute extends CampaignRoute<{
.toISOString()
.slice(0, 19)
.replace("T", " "),
reviewerType: bug.reviewerType as ReviewerType,
};
});
}
Expand Down
1 change: 0 additions & 1 deletion src/routes/media/_post/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import debugMessage from "@src/features/debugMessage";
import upload from "@src/features/upload";
import { Context } from "openapi-backend";
import path from "path";
import fs from "fs";
import busboyMapper from "@src/features/busboyMapper";

/** OPENAPI-ROUTE: post-media */
Expand Down
Loading
Loading