cap 1609 fixes samples for Go lang #187
Open
+205
−258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small fixes to find the external module dependencies
The EncTest that the wrappers run is interactive (it asks the user to provide a password.) Changed it to non-interactive. This is needed so that they do not fail when ran from the CorePWSTester.
The Go DataExtraction_test was failing because of a call to set a new Rect with int values but the call expects floats.
overocean
reviewed
Jan 15, 2026
Samples/EncTest/GO/Enc_test.go
Outdated
| for count < 3{ | ||
| fmt.Println("A password required to open the document.") | ||
| var password string | ||
| fmt.Print("Please enter the password: \n") |
Contributor
There was a problem hiding this comment.
Can we remove this line and also the commented out lines?
Addressing PR comments
- Fixes for the OCRTest samples to work with the IRIS OCR module if present. Before the change, if the module is present, and we are not requesting the use of that module, it was giving an error. - Removed test case number 7 from these tests as it was previously removed from the CPP and Java tests but not from these. Test 7 is expected to fail.
Small fix for PHP OCRTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataExtraction_test.go: fixed values expected to be float's not int's. Int's were throwing an exception.
PDF2Html_test.go, PDF2Office_test.go: fixed path to the external module the tests need.
Enc_test.go, EncTest.php, EncTest.py, EntTest.rb: changed test from interactive (requiring user to enter the password "test") to automated so that the tests don't hang indefinitely waiting, or if there's not input, keep trying with wrong empty password.)