-
Notifications
You must be signed in to change notification settings - Fork 7
Prevent vale style review from removing code blocks #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nearestnabors
wants to merge
6
commits into
main
Choose a base branch
from
fix/vale-review-no-code-removal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+158
−11
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
66df994
Prevent vale style review from removing code blocks
nearestnabors 8c44a35
Fix inconsistent length validation and prompt contradiction in vale-s…
cursoragent e805c99
Fix nested code block detection in getLinesInCodeBlocks
cursoragent 827e256
Fix CommonMark code fence parsing bugs in vale-style-review
cursoragent b7c17ed
Fix lint errors in vale-style-review.ts
nearestnabors 606e9b4
Fix: Support tilde-fenced code blocks in vale-style-review
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/.vale.ini
Line 18 in 35be995
I think maybe it's missing parentheses around the rule:
(?s)([\s\S]*?)or
(?s)*([\s\S]*?)if there may be leading whitespace (I don't think that would be true for a code block)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude Code:
The issue: Vale's BlockIgnores regex doesn't work for fenced code blocks because:
works for most content, BUT lines starting with # inside code blocks get misidentified as
headings.
- No code scopes are created → IgnoredScopes = code doesn't help
- BlockIgnores regex is supposed to work but has known issues
(BlockIgnores not working for .mdx files errata-ai/vale#115, Vale is picking up errors for stuff in code blocks in GitHub markdown errata-ai/vale#387)
The bottom line: The commenter's suggestion about parentheses won't fix it - it's a Vale
limitation for MDX files. That's exactly why this PR's vale-style-review.ts script adds its own
getLinesInCodeBlocks() function to detect code blocks independently.