Skip to content

Conversation

@raymondjacobson
Copy link
Member

1. Fixed crash on mobile profile page load

  • Issue: Profile page was crashing with TypeError: Cannot read properties of undefined (reading 'current') when accessing tab refs
  • Root cause: interpolateScale function in useTabs hook was accessing .current on potentially undefined refs when tabs array was empty during loading
  • Fix: Added optional chaining (?.) when accessing refs in interpolateScale function
  • File: packages/web/src/hooks/useTabs/useTabs.tsx

2. Fixed empty tabs content on mobile profile page

  • Issue: After fixing the crash, tabs were rendering but showing no content
  • Root cause: profileTabs and profileElements were being computed after useTabs hook was called, so the hook received empty arrays. React hooks don't react to variable assignments that happen after the hook call.
  • Fix: Moved tab and element computation into useMemo hook that runs before useTabs, matching the pattern used in the desktop version
  • File: packages/web/src/pages/profile-page/components/mobile/ProfilePage.tsx

UI Improvements

3. Added spacing between coin icon and tier text in ProfilePageBadge

  • Added gap: 12px to .isCompact container to create proper spacing between the coin icon and "TIER 3 GOLD" text
  • File: packages/web/src/components/user-badges/ProfilePageBadge.module.css

4. Added spacing between "Show More" link and tip button

  • Added margin-bottom: 16px to .expandDescription class to improve visual separation
  • File: packages/web/src/pages/profile-page/components/mobile/ProfileHeader.module.css

Testing

  • Verified mobile profile page loads without crashing
  • Confirmed tabs display content correctly for both artist and user profiles
  • Verified spacing improvements are visible in the UI

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2026

⚠️ No Changeset found

Latest commit: 2fa0429

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@raymondjacobson raymondjacobson merged commit b0d576a into main Jan 19, 2026
4 checks passed
@raymondjacobson raymondjacobson deleted the rj-mobile-pp branch January 19, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants