-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Core} Add discernable telemetry for --help commands
#32714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Core} Add discernable telemetry for --help commands
#32714
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds telemetry tracking for help commands by including --help in the parameters field of telemetry data. Previously, help commands (using --help, -h, or help) were not easily queryable in telemetry.
Changes:
- Modified
format_help()method inparser.pyto includeparameters=['--help']when setting telemetry command details
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yanzhudd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good to me
Related command
Description
Previously, there was no way in telemetry to query commands from the
--helpfamily. This PR add--helpto the telemetry payload (using theParamsproperty).Tested conditions:
az helpaz --helpaz -h--help-h--help-hIsCmdIdxRebuildTriggeredstill set correctlyKustoTo query in Kusto:
Commands (successful) sent from this branch:
In Kusto, there are many records already with
Paramsset to--help, however they are only for records whereActionResult!=Success. It appears records can make it to Kusto withParamsset to--helpif someone has setextension.use_dynamic_install=yes_promptand cancel out of a prompt to install an extension, initiated by a command appended with--help, i.e.,az monitor scheduled-query --help.You can view these records with this query:
The ResultSummary="show help" records appearing in Kusto are from legacy dev environments running editable installs that report as version 0.1.1b3+dev. These use the old event naming convention (azurecli/commands/vm) which isn't in the suppression list, while modern versions use azurecli/command (which is suppressed). The fix is working correctly for production users.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.