Add npm package artifact generation to test workflow #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update test workflow to generate npm package tar.gz files
Add npm package artifact generation to test workflow
Jan 31, 2026
mikeharder
previously requested changes
Jan 31, 2026
…ct name Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
mikeharder
reviewed
Jan 31, 2026
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Member
|
@copilot: While we're here, upgrade all actions in this file to their latest versions. Also, upgrade the node version from 22 to 24 (but keep using node 20). |
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Add npm package artifact generation to test workflow
Add npm package artifact generation and upgrade actions in test workflow
Jan 31, 2026
mikeharder
reviewed
Jan 31, 2026
mikeharder
reviewed
Jan 31, 2026
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Member
|
@copilot: revert changes to upgrade actions versions and node version |
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Add npm package artifact generation and upgrade actions in test workflow
Add npm package artifact generation to test workflow
Jan 31, 2026
mikeharder
requested review from
AkhilaIlla,
raosuhas,
tejaswiMinnu and
weshaggard
as code owners
mikeharder
approved these changes
Jan 31, 2026
mikeharder
reviewed
Jan 31, 2026
.github/workflows/test.yaml
Outdated
|
|
||
| - name: Upload npm packages | ||
| if: contains(matrix.os, 'ubuntu') | ||
| uses: actions/upload-artifact@v4 |
mikeharder
reviewed
Jan 31, 2026
.github/workflows/test.yaml
Outdated
| name: packages | ||
| path: | | ||
| packages/**/*.tgz | ||
| !packages/**/node_modules/**/*.tgz |
Member
There was a problem hiding this comment.
@copilot: would it be safer to exclude everything under node_modules? if so, do we even need the last **?
Contributor
Author
There was a problem hiding this comment.
Done in 187db23 - changed to !packages/**/node_modules/** to exclude everything under node_modules (not just .tgz files). The ** at the end is needed to match any files/directories at any depth within node_modules.
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
AkhilaIlla
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the test workflow to generate and upload npm package artifacts.
Changes Made
Artifact Generation
rush packstep to generate package tarballs (.tgz files)actions/upload-artifact@v6contains(matrix.os, 'ubuntu')packagesnode_modulesdirectories from artifact uploadArtifacts Produced
The workflow generates and uploads three npm package tarballs:
@microsoft.azure/openapi-validator@microsoft.azure/openapi-validator-core@microsoft.azure/openapi-validator-rulesetsThese artifacts are uploaded only from the ubuntu runner to avoid duplication, with the upload step configured to fail if no .tgz files are found. Everything within node_modules directories is excluded from the upload.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.