Fix equality checks #168
Merged
Fix equality checks #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…null_ptr Fortran's c_associated intrinsic has non-intuitive semantics and does not directly function as an equality comparison
In the absence of -O3, it has been observed with gcc 14.2..15.2 that when pproc is a pointer to proc, the combination c_f_procpointer(c_funloc(proc), pproc2) can produce a pproc2 that differs from pproc by 12 bytes. However the expression: c_f_procpointer(c_funloc(pproc), pproc2) (passing a procedure pointer to c_funloc rather than the procedure itself) seems to more reliably produce a pproc2 that matches pproc. This might be a compiler bug, or possibly intentional behavior. It's unclear whether this is a violation of the standard.
…quals Was previously testing as equals when one diagnosis_function_ was associated and the other was not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
Fixes #167