Skip to content

feat(express): add derivedFromParentWithSeed for isWalletAddress #7981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaustubhbitgo merged 1 commit into from
Jan 28, 2026
Merged

feat(express): add derivedFromParentWithSeed for isWalletAddress #7981

kaustubhbitgo merged 1 commit into from
Jan 28, 2026
+225 −0

Conversation

@kaustubhbitgo
Copy link
Contributor

@kaustubhbitgo kaustubhbitgo commented Jan 28, 2026

Ticket: WP-7522

@kaustubhbitgo kaustubhbitgo marked this pull request as ready for review January 28, 2026 05:37
@kaustubhbitgo kaustubhbitgo requested review from a team as code owners January 28, 2026 05:37
Marzooqa
Marzooqa reviewed Jan 28, 2026
View reviewed changes
Copy link
Contributor

@Marzooqa Marzooqa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add validation to make sure this field is present when walletType is "cold" ie, SMC wallets and isn't required otherwise?

@kaustubhbitgo
Copy link
Contributor Author

kaustubhbitgo commented Jan 28, 2026

Can you add validation to make sure this field is present when walletType is "cold" ie, SMC wallets and isn't required otherwise?

That's a lot of validation on express side. I can make a follow-up PR on SDK side if that is not done. We should ideally reject from SDK not from express unless it's io-ts issue.

@kaustubhbitgo kaustubhbitgo merged commit 2701c9d into master Jan 28, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Marzooqa Marzooqa Marzooqa left review comments

@adityasoni-bitgo adityasoni-bitgo adityasoni-bitgo approved these changes

@alextse-bg alextse-bg Awaiting requested review from alextse-bg alextse-bg is a code owner automatically assigned from BitGo/wallet-core

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaustubhbitgo @Marzooqa @adityasoni-bitgo