REV: Bad Data Neighbor Orientation Check #1499
Open
+1,225
−368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nyoungbq
commented
Jan 8, 2026
nyoungbq
commented
- Cleaned up algorithm,filter, and test case code
- Removed preflight checks that are already preformed by parameters
- Added Test case using real world data compared against 6.5 output
- Added extensive readme about data and testing methodology in new test data file
- Verified and documented the identical results between 6.5 and NX
nyoungbq
requested review from
imikejackson
and removed request for
imikejackson
imikejackson
force-pushed
the
review/bad_data_neighbor_misorientation_check
branch
from
4d4b95e to
53abeef
Compare
nyoungbq
force-pushed
the
review/bad_data_neighbor_misorientation_check
branch
from
e648c56 to
32fa332
Compare
imikejackson
changed the title
imikejackson
force-pushed
the
review/bad_data_neighbor_misorientation_check
branch
from
f9fbc48 to
7cf0ac5
Compare
- Add a test case to test a real world dataset against 6.5 output - Cleaned up test namespace - merged old test case file into new test file
…of neighbors - 18 Test Cases to validate base cases
nyoungbq
force-pushed
the
review/bad_data_neighbor_misorientation_check
branch
from
7cf0ac5 to
a37ca86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.