Fix: Remove short flags from non-boolean typer.Option definitions #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Chat2AnyLLM#48 ## Problem CAM failed to initialize with "TypeError: Secondary flag is not valid for non-boolean flag" when running any command. The error occurred during Typer/Click CLI initialization. ## Root Cause Throughout the codebase, non-boolean typer.Option() definitions incorrectly included short flags (e.g., -c, -s, -n, -o, -b, -f, -d, -a, -l, -m). In Click/Typer, only boolean flags can have both a long form (--flag) and short form (-f). Non-boolean options (strings, paths, integers, etc.) can only use long-form flags. ## Changes - Removed short flags from all non-boolean typer.Option definitions across 12 files in cli/ and mcp/ directories - Fixed parameter name conflict in prompts_commands.py where 'default' parameter conflicted with boolean flag syntax - Boolean options (with True/False as first argument) retain their short flags ## Affected Files - cli/agents_commands.py - cli/app.py - cli/options.py - cli/plugins/plugin_discovery_commands.py - cli/plugins/plugin_install_commands.py - cli/plugins/plugin_management_commands.py - cli/plugins/plugin_marketplace_commands.py - cli/prompts_commands.py - cli/skills_commands.py - mcp/cli.py - mcp/install_commands.py - mcp/server_commands.py ## Testing Verified that CLI initializes successfully and no TypeError is raised: ```python from code_assistant_manager.cli import app from typer.main import get_command cmd = get_command(app) # No error ``` Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48
Problem
CAM failed to initialize with
TypeError: Secondary flag is not valid for non-boolean flagwhen running any command. The error occurred during Typer/Click CLI initialization, making the tool completely unusable.Root Cause
Throughout the codebase, non-boolean
typer.Option()definitions incorrectly included short flags (e.g.,-c,-s,-n,-o,-b,-f,-d,-a,-l,-m).In Click/Typer, only boolean flags can have both a long form (
--flag) and short form (-f). Non-boolean options (strings, paths, integers, etc.) can only use long-form flags.Solution
typer.Optiondefinitions across 12 filesprompts_commands.pywhere thedefaultparameter name conflicted with boolean flag syntaxTrue/Falseas first argument) retain their short flags as they are allowedChanges
Files Modified (12 total)
cli/agents_commands.pycli/app.pycli/options.pycli/plugins/plugin_discovery_commands.pycli/plugins/plugin_install_commands.pycli/plugins/plugin_management_commands.pycli/plugins/plugin_marketplace_commands.pycli/prompts_commands.pycli/skills_commands.pymcp/cli.pymcp/install_commands.pymcp/server_commands.pyExample Changes
Before:
After:
Boolean flags (unchanged):
Testing
Verified that CLI initializes successfully without errors:
Impact
Breaking Changes
Users who were using short flags for non-boolean options will need to switch to long flags:
-c→--config-s→--scope-n→--name-o→--ownerHowever, since the tool was completely broken before this fix, there are likely no active users relying on these short flags.
Note: This PR was created with assistance from Claude Code after discovering and documenting the issue in #48.