Skip to content

fix: issue with instrument hooks failing in codspeed benchmark #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
not-matthias merged 6 commits into from
Jan 20, 2026
Merged

fix: issue with instrument hooks failing in codspeed benchmark #19

not-matthias merged 6 commits into from
Jan 20, 2026

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Jan 19, 2026 •
edited
Loading

  • We had an edge case, where we could read messages of a previous command that didn't completely drain the FIFO pipe. This has been fixed by fully flushing the pipe on .deinit.
  • Properly check the version response, to ensure that we print the right error message
  • Added a logger to allow easier printing/debugging
  • Added more logs to make it easier to debug instrument-hooks

@not-matthias not-matthias mentioned this pull request Jan 19, 2026
Merged
@not-matthias not-matthias removed the request for review from GuillaumeLagrange January 19, 2026 15:35
@not-matthias not-matthias force-pushed the cod-2039-issue-with-instrument-hooks-failing-in-codspeed-benchmark branch from ad53346 to f951c44 Compare January 19, 2026 18:43
@not-matthias not-matthias force-pushed the cod-2039-issue-with-instrument-hooks-failing-in-codspeed-benchmark branch from f951c44 to d85eb32 Compare January 20, 2026 09:52
@not-matthias not-matthias changed the title cod 2039 issue with instrument hooks failing in codspeed benchmark fix: issue with instrument hooks failing in codspeed benchmark Jan 20, 2026
GuillaumeLagrange
GuillaumeLagrange approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@not-matthias not-matthias merged commit 89fb72a into main Jan 20, 2026
92 checks passed
@not-matthias not-matthias deleted the cod-2039-issue-with-instrument-hooks-failing-in-codspeed-benchmark branch January 20, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeLagrange GuillaumeLagrange GuillaumeLagrange approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@not-matthias @GuillaumeLagrange