fix: additional allocations (128b) #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-matthias
changed the base branch from
main
to
cod-2039-issue-with-instrument-hooks-failing-in-codspeed-benchmark
not-matthias
changed the title
GuillaumeLagrange
approved these changes
Jan 20, 2026
Contributor
GuillaumeLagrange
left a comment
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
olgtm, good catch!
not-matthias
force-pushed
the
cod-1779-investigate-additional-allocations-128b
branch
from
a6a4ceb to
89fb72a
Compare
not-matthias
merged commit 89fb72a
into
cod-2039-issue-with-instrument-hooks-failing-in-codspeed-benchmark
46 checks passed
not-matthias
deleted the
cod-1779-investigate-additional-allocations-128b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to allocate a buffer for reading/sending the commands. Since we don't handle the
Start/StopSamplemarkers in instrument-hooks (for backwards compatibility reasons) we'll have to always perform those recvs/sends.However, instead of allocating the required memory at runtime we now have a static buffer which is definitely big enough for all the commands that we currently have and ever will have (otherwise we can always bump it).