Skip to content

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Jan 28, 2026

No description provided.

@not-matthias not-matthias force-pushed the cod-2105-support-memory-profiling-for-python branch from 55eeef1 to 4bd794f Compare January 28, 2026 17:51
@not-matthias not-matthias marked this pull request as ready for review January 28, 2026 17:51
@not-matthias not-matthias force-pushed the cod-2105-support-memory-profiling-for-python branch from 2351156 to c6a08d7 Compare January 28, 2026 17:59
@avalanche-staging
Copy link

avalanche-staging bot commented Jan 28, 2026

Congrats! CodSpeed is installed 🎉

🆕 330 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks


ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Open in CodSpeed

- name: Run benchmarks
uses: CodSpeedHQ/action@main
with:
runner-version: branch:cod-2105-support-memory-profiling-for-python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not forget to drop this commit

sudo apt-get install valgrind -y
uv sync --dev
sudo apt-get remove valgrind -y
- uses: dtolnay/rust-toolchain@stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant to request changes

Especially we need to validate the extra stack frame thing in instrumentation by comparing the output to a real prod run!

@not-matthias not-matthias force-pushed the cod-2105-support-memory-profiling-for-python branch from 1f5d7cf to e15aad8 Compare January 30, 2026 14:25
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2026

Merging this PR will degrade performance by 16.62%

⚡ 11 improved benchmarks
❌ 24 regressed benchmarks
✅ 132 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_multiprocessing_map[10000] 101.3 ms 121.4 ms -16.62%
WallTime test_threadpool_map[100000] 3.9 s 3.8 s +2.76%
WallTime test_fs_read[1000] 857.1 ns 778.9 ns +10.05%
WallTime test_generate_all_combinations[5-4] 10.8 µs 11 µs -2.14%
WallTime test_iir_filter_process 3.2 µs 3.1 µs +3.52%
WallTime test_hamilton_cycle[graph0] 24.5 µs 25 µs -2.2%
WallTime test_process_creation[cat /dev/null] 4.9 ms 5.3 ms -7.27%
WallTime test_pipe_communication[10000] 15.3 ms 15.6 ms -2.28%
WallTime test_threadpool_map[10] 2.5 ms 2.6 ms -2.14%
WallTime test_recursive_fibo_20 5.5 ms 5.3 ms +3.62%
WallTime test_multiprocessing_map[1000] 57 ms 65.5 ms -12.96%
WallTime test_threadpool_map[10000] 367.4 ms 377.9 ms -2.78%
WallTime test_sum_of_squares[sum_of_squares_sum_labmda_power] 287.2 µs 295.1 µs -2.68%
WallTime test_noop_lambda_decorated 1.3 µs 1.3 µs -4.57%
WallTime test_color[graph0-3] 27.4 µs 28 µs -2.09%
WallTime test_mmap_operation[409600] 130.2 µs 134.1 µs -2.88%
WallTime test_solve_crossword[puzzle0-words0] 2.2 µs 2.1 µs +2.52%
WallTime test_tcp_connection[1.1.1.1-53] 834.6 µs 882.6 µs -5.44%
WallTime test_process_creation[ls -l] 6.2 ms 6.7 ms -6.51%
WallTime test_combination_sum[candidates0-8] 11.8 µs 12.1 µs -2.65%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing cod-2105-support-memory-profiling-for-python (fc8f559) with master (adee8a1)

Open in CodSpeed

@not-matthias not-matthias force-pushed the cod-2105-support-memory-profiling-for-python branch 2 times, most recently from 504d9a3 to 373acb4 Compare January 30, 2026 14:46
@not-matthias not-matthias force-pushed the cod-2105-support-memory-profiling-for-python branch from 373acb4 to fc8f559 Compare January 30, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants