Prevent people from pinging @channel #387
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabbate19
previously requested changes
Nov 19, 2023
Contributor
|
@MeMyselfMirai If you fix the merge conflict (It's a formatting thing), this looks very good. I'd like to see this in dev |
Qelxiros
reviewed
Dec 25, 2025
Contributor
|
oh this is super old |
Contributor
Disagree. If @MeMyselfMirai doesn't want to do it, I will, I just want to give the original author a chance first |
BigSpaceships
dismissed stale reviews from jabbate19 and Qelxiros
joe said to dismiss on slack but was at work so no review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You're welcome Joe.
A few days ago, this happened:
This change inserts spaces after any @ signs in major project submissions. This should prevent such a ping from happening again.