adjust version update PR wrt actual updates #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This workflow change makes the automated version-bump PRs clearly indicate which NATS tools actually changed and structures the commit message/body dynamically based on the updates.
Changes:
- Refactors the update logic into a reusable
update_onefunction that tracks which tools were updated and builds a structured commit message and PR body table. - Adjusts step outputs (
updated,which_tools, and a JSONcommitpayload) to drive the PR title, commit message, and body from theupdate_versionsstep. - Simplifies and unifies how current and latest versions are written to
$GITHUB_OUTPUT.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying nats-tools with
|
| Latest commit: |
4086b6f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e6612bea.nats-tools.pages.dev |
| Branch Preview URL: | https://pdp-update-workflow-filter-c.nats-tools.pages.dev |
We have two tools and often only one updates at a time. An example of a PR generated by the prior state is <#65>. It's ugly that we have to read so carefully to note that `nsc` was not updated there. Unfortunately with GHActions YAML, making the body more dynamic required ugliness elsewhere, namely serializing text into JSON to put it into a single line, to pass as an output between steps.
philpennock
force-pushed
the
pdp/update-workflow-filter-claims
branch
from
94c3216 to
4086b6f
Compare
Contributor
Author
|
(force-push to rebase instead of merge in main) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two tools and often only one updates at a time. An example of a PR generated by the prior state is
#65.
It's ugly that we have to read so carefully to note that
nscwas not updated there.Unfortunately with GHActions YAML, making the body more dynamic required ugliness elsewhere, namely serializing text into JSON to put it into a single line, to pass as an output between steps.