feat: add lf flag on insights projects update (CM-888)

[ulemons]

Summary

This pull request implements automatic management of Linux Foundation collection connections based on the isLF flag on insights projects.

What Changed

Automatic Collection Management

• When a project has isLF = true, it is automatically added to the Linux Foundation collection
• When a project's isLF flag changes from true to false, it is automatically removed from the Linux Foundation collection
• This happens during both project creation and updates

How It Works

1. Project Creation: When creating a new insights project with isLF = true, the project is automatically connected to the Linux Foundation collection

2. Project Updates: When updating a project:

   • If isLF changes to true → automatically adds to LF collection
   • If isLF changes to false → automatically removes from LF collection
   • If collections are explicitly provided → uses those collections
   • If only isLF changes → preserves existing collections and only manages LF connection

---

Note

Implements automatic Linux Foundation collection membership management for insights projects.

• Adds linuxFoundation config (with collectionId) to default.json, production.json, and staging.json
• Introduces LinuxFoundationConfiguration type and exports LINUX_FOUNDATION_CONFIG and ENABLE_LF_COLLECTION_MANAGEMENT
• Updates CollectionService to auto-manage LF collection connection on project create/update via manageLfCollectionConnection, preserving explicit or existing collections and reacting to isLF changes
• Skips auto-management when the feature flag is disabled or collectionId is not configured

^{Written by Cursor Bugbot for commit 4005eeb. This will update automatically on new commits. Configure here.}

[Copilot]

Pull request overview

This PR adds automatic management of Linux Foundation (LF) collection connections for insights projects based on their isLF flag. When a project's isLF flag is set to true (either directly or via segment association), it automatically adds the project to the LF collection. Conversely, setting it to false removes the project from the LF collection.

Changes:

• Added a constant for the Linux Foundation collection ID
• Created a new method manageLfCollectionConnection to manage automatic LF collection connections
• Modified createInsightsProject to automatically add LF projects to the LF collection during creation
• Modified updateInsightsProject to automatically manage LF collection connections when the isLF flag changes

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gaspergrom]

Code Review

🔴 Critical Issue: Inconsistent isCurrentlyConnectedToLF Logic

In manageLfCollectionConnection (collectionService.ts:598-601):

const isCurrentlyConnectedToLF = currentConnections.some(
  (c) => c.collectionId === linuxFoundationCollectionId,
)

let updatedCollections = [...desiredCollections]

The method checks isCurrentlyConnectedToLF based on current database state, but then operates on desiredCollections (the user's requested collections). This creates a potential logic issue:

• If desiredCollections already includes the LF collection (user explicitly added it) and isLF=true, the code correctly avoids duplicates ✅
• But if desiredCollections doesn't include the LF collection (user explicitly removed it) and isLF=true, the code will re-add it, potentially overriding user intent ⚠️

Question: Should automatic LF collection management override explicit user requests to remove a project from the LF collection? If not, the logic needs adjustment to respect user intent.

---

Other Recommendations

1. Missing Tests - No test files included. Given the complexity of state management (isLF flag changes, collection preservation), unit tests for manageLfCollectionConnection would be valuable.

2. Type Safety - existingConnections?: any[] should use a proper type like CollectionProjectConnection[] | null

3. Unnecessary ESLint Disable - Line 564 has // eslint-disable-next-line class-methods-use-this but the method uses this.log, so this appears incorrect.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.