refactor: stop writing to old repositories tables[CM-905] #3776

mbani01 · 2026-01-23T09:43:14Z

This pull request removes legacy repository management logic and updates database references to streamline how repositories are tracked and managed across the codebase. The changes focus on eliminating the use of old per-platform repository tables (git.repositories, githubRepos, gitlabRepos) and their associated repository classes, and instead rely on the unified repositories table. Additionally, related foreign key constraints in the database are updated to reference the new structure.

Key changes include:

1. Removal of Legacy Repository Management Logic

Deleted the GitReposRepository, GithubReposRepository, and GitlabReposRepository classes, which previously handled repository CRUD operations for their respective tables. All related logic for soft-deleting, upserting, and mapping repositories in these legacy tables has been removed from the codebase. [1] [2] [3]
Removed all usage and imports of these classes from integrationService.ts, including all code paths that performed soft deletes or mapping updates in the legacy tables. [1] [2] [3] [4] [5] [6] [7]

2. Migration to Unified Repository Table

Updated code in integrationService.ts to interact only with the unified repositories table for all repository management operations, including upserts, deletions, and mapping logic. The code no longer references or syncs with git.repositories or other legacy tables. [1] [2] [3]

3. Database Schema Updates

Updated foreign key constraints in the database to reference the unified repositories table instead of the old git.repositories table, including cascading deletes for related tables (maintainersInternal, git.serviceExecutions). [1] [2]

These changes simplify repository management, reduce technical debt, and ensure all repository-related data is managed consistently in a single place.

Note

Consolidates repository management on the unified public.repositories table and removes legacy per-platform repo logic.

Database: Update FKs to reference public.repositories (maintainersInternal.repoId, git.serviceExecutions.repoId) with ON DELETE CASCADE.
Backend services: Refactor integrationService to read/write only public.repositories; drop all interactions with git.repositories, githubRepos, gitlabRepos; generate repository IDs via uuid(); simplify deletion/mirroring validation and soft-deletes through unified APIs.
Nango worker: Remove legacy GitHub repo mapping calls; add/update repos directly via upsertRepository and soft-delete via unified helpers; keep Git integration remotes in sync.
Cronjob: Query/update archival status from public.repositories only.
Common services/DAL: Stop writing to segmentRepositories; update insights syncing to derive from unified repositories; remove obsolete repo-mapping utilities.

^{Written by Cursor Bugbot for commit 6ba2fc5. This will update automatically on new commits. Configure here.}

…ositories

Copilot

Pull request overview

This PR removes legacy per-platform repository table logic (git.repositories, githubRepos, gitlabRepos) and consolidates repository management around the unified public.repositories table, including updating related foreign key constraints.

Changes:

Removed legacy repository mapping/sync functions and repository classes tied to githubRepos, gitlabRepos, and git.repositories.
Updated GitHub Nango workflows/activities and backend integration logic to stop writing to legacy tables and to use public.repositories.
Added DB migrations to repoint FK constraints (e.g., git.serviceExecutions, maintainersInternal) to public.repositories.

Reviewed changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
services/libs/data-access-layer/src/repositories/index.ts	Removes helper that queried legacy `git.repositories` IDs by URL.
services/libs/data-access-layer/src/integrations/index.ts	Deletes legacy GitHub repo mapping + git V2 sync logic; updates deletion to target `public.repositories`.
services/libs/common_services/src/services/integration.service.ts	Stops unmapping GitHub legacy table; relies on unified repository deletion.
services/apps/nango_worker/src/workflows/syncGithubIntegration.ts	Removes legacy mapping steps; keeps only unified repository operations.
services/apps/nango_worker/src/activities/nangoActivities.ts	Removes legacy GitHub repo mapping calls; updates Git integration update and repository upsert flow.
services/apps/nango_worker/src/activities.ts	Stops exporting removed legacy activity.
backend/src/services/integrationService.ts	Removes legacy repo-table writes/reads; updates unified repository mapping flow.
backend/src/database/migrations/V1769097489__changeGitServiceExecutionRefreneceToRepositories.sql	Updates `git.serviceExecutions.repoId` FK to reference `public.repositories`.
backend/src/database/migrations/V1769092368__changeMaintainersRepoReferenceToRepositories.sql	Updates `maintainersInternal.repoId` FK to reference repositories.
backend/src/database/migrations/U1769097489__changeGitServiceExecutionRefreneceToRepositories.sql	Added undo migration file (currently empty).
backend/src/database/migrations/U1769092368__changeMaintainersRepoReferenceToRepositories.sql	Added undo migration file (currently empty).
backend/src/database/repositories/{gitReposRepository,githubReposRepository,gitlabReposRepository}.ts	Deletes legacy repository repository classes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-23T09:47:48Z

backend/src/services/integrationService.ts

+    const isGitHubPlatform = [PlatformType.GITHUB, PlatformType.GITHUB_NANGO].includes(
+      sourcePlatform,
+    )
+    const sourceIntegration = isGitHubPlatform ? IntegrationRepository.findById(sourceIntegrationId, txOptions) : null


sourceIntegration is assigned the Promise returned by IntegrationRepository.findById(...), but later treated like a resolved integration object (sourceIntegration?.settings?.orgs). This makes the forkedFrom map never populate and can lead to incorrect forkedFrom values. Await the lookup (or include it in the existing async flow) before accessing .settings.

Suggested change

const sourceIntegration = isGitHubPlatform ? IntegrationRepository.findById(sourceIntegrationId, txOptions) : null

const sourceIntegration = isGitHubPlatform

? await IntegrationRepository.findById(sourceIntegrationId, txOptions)

: null

Copilot · 2026-01-23T09:47:48Z

backend/src/services/integrationService.ts

-import GitReposRepository from '../database/repositories/gitReposRepository'
-import GithubReposRepository from '../database/repositories/githubReposRepository'
-import IntegrationRepository from '../database/repositories/integrationRepository'
+import IntegrationRepository from '../database/repositories/integrationRepository'  


This import line has trailing whitespace, which can cause lint/prettier failures in repos that enforce no-trailing-spaces.

Suggested change

import IntegrationRepository from '../database/repositories/integrationRepository'

import IntegrationRepository from '../database/repositories/integrationRepository'

Copilot · 2026-01-23T09:47:49Z

...nd/src/database/migrations/V1769097489__changeGitServiceExecutionRefreneceToRepositories.sql

@@ -0,0 +1,8 @@
+-- Drop the existing foreign key constraint to git.repositories


Migration filename contains a typo: "Refrenece". Renaming to "Reference" will improve clarity and make it easier to find/search for this migration later.

Copilot · 2026-01-23T09:47:49Z

services/libs/common_services/src/services/integration.service.ts

    for (const repo of reposToBeRemoved) {
-      await removePlainGitHubRepoMapping(qx, redis, integrationId, repo)
      await removePlainGitlabRepoMapping(qx, redis, integrationId, repo)
    }


This loop is unmapping GitHub Nango repos, but it now calls removePlainGitlabRepoMapping(...) (which is no longer GitLab-specific). Renaming the DAL function (and updating this call site) would make the intent clearer and prevent accidental platform-specific assumptions later.

Copilot · 2026-01-23T09:47:49Z

backend/src/database/migrations/V1769092368__changeMaintainersRepoReferenceToRepositories.sql

+ADD CONSTRAINT "maintainersInternal_repoId_fkey"
+FOREIGN KEY ("repoId")
+REFERENCES repositories(id)
+ON DELETE CASCADE;


This migration uses REFERENCES repositories(id) without a schema qualifier, while other migrations in this repo typically qualify (e.g., REFERENCES git.repositories(id) in V1762938833__migrateMaintainersRepoReferenceToGitRepositories.sql and REFERENCES public.repositories(id) in V1766669430__createGitRepositoryProcessingTable.sql). Prefer public.repositories(id) here for consistency and to avoid relying on search_path.

Copilot · 2026-01-23T09:47:50Z

...nd/src/database/migrations/V1769097489__changeGitServiceExecutionRefreneceToRepositories.sql

@@ -0,0 +1,8 @@
+-- Drop the existing foreign key constraint to git.repositories
+ALTER TABLE git."serviceExecutions" 
+    DROP CONSTRAINT "serviceExecutions_repoId_fkey";


DROP CONSTRAINT is executed without IF EXISTS, which can make the migration fail if the constraint name differs across environments or has already been removed. Consider using DROP CONSTRAINT IF EXISTS ... (as done in V1769092368__changeMaintainersRepoReferenceToRepositories.sql).

Suggested change

DROP CONSTRAINT "serviceExecutions_repoId_fkey";

DROP CONSTRAINT IF EXISTS "serviceExecutions_repoId_fkey";

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

backend/src/services/integrationService.ts

…g git integration duplicates

mbani01 added 10 commits January 22, 2026 15:53

chore: db migration to switch maintainersRepo reference to public.rep…

3858c7e

…ositories

chore: deprecate removeGitHubRepoMapping to delete from githubRepos

7c6e8d3

chore: deprecate mapGithubRepo

ffc2ded

chore: deprecate removePlainGitHubRepoMapping

8c40f39

chore: deprecate githubReposRepository

6fe75f9

chore: deprecate git.repositories table

e983869

chore: deprecate git.repositories table

db37ca4

chore: change git.SE repo reference to public.repositories

ca910e9

chore: deprecate gitlabRepos

3c5f932

chore: fix lint & format

f25e61d

mbani01 requested a review from Copilot January 23, 2026 09:43

mbani01 self-assigned this Jan 23, 2026

Copilot started reviewing on behalf of mbani01 January 23, 2026 09:43 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

mbani01 added 4 commits January 23, 2026 11:01

chore: deprecate segmentRepositories

de5f592

chore: deprecate segmentRepositories from archived_repo checker

9f56955

fix: legacy github repos sync

b3728f4

fix: lint

3c0bbde

This comment was marked as outdated.

Sign in to view

mbani01 added 2 commits January 23, 2026 14:34

fix: lint

674c0d9

fix: format

77c9083

mbani01 requested a review from ulemons January 23, 2026 13:43

cursor bot reviewed Jan 23, 2026

View reviewed changes

backend/src/services/integrationService.ts Show resolved Hide resolved

fix: using gitIntegrationId instead of sourceIntegration when checkin…

6ba2fc5

…g git integration duplicates

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: stop writing to old repositories tables[CM-905] #3776

refactor: stop writing to old repositories tables[CM-905] #3776

mbani01 commented Jan 23, 2026 •

edited by cursor bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	import IntegrationRepository from '../database/repositories/integrationRepository'
	import IntegrationRepository from '../database/repositories/integrationRepository'

		@@ -0,0 +1,8 @@
		-- Drop the existing foreign key constraint to git.repositories

	DROP CONSTRAINT "serviceExecutions_repoId_fkey";
	DROP CONSTRAINT IF EXISTS "serviceExecutions_repoId_fkey";

refactor: stop writing to old repositories tables[CM-905] #3776

Are you sure you want to change the base?

refactor: stop writing to old repositories tables[CM-905] #3776

Conversation

mbani01 commented Jan 23, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mbani01 commented Jan 23, 2026 •

edited by cursor bot

Loading