Skip to content

Conversation

@Yannick1712
Copy link
Member

Release Checklist

Pre-Release

  • Check migrations
    • No database related infos (sqldb-xxx)
    • Impact on GS (new/removed columns)
  • Check for linter errors (in PR)
  • Test basic user operations (on DFX services)
    • Login/logout
    • Buy/sell payment request
    • KYC page

Post-Release

  • Test basic user operations
  • Monitor application insights log

Comment on lines +287 to +289
for (const recommendation of recommendations) {
await this.userDataService.blockUserData(recommendation.recommender, 'manual root block - recommended');
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will block the same user data multiple times?

Comment on lines +284 to +286

await this.userDataService.blockUserData(userData, 'manual root block');

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root is a bit difficult 🤣 maybe just use recommendation, associates, linked, circle 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants