Skip to content

Conversation

@xlamn
Copy link
Collaborator

@xlamn xlamn commented Jan 29, 2026

  • before it was only checked if the account has KycStepName.REALUNIT_REGISTRATION
  • now it is checked if the wallet is included in the KycStep

Release Checklist

Pre-Release

  • Check migrations
    • No database related infos (sqldb-xxx)
    • Impact on GS (new/removed columns)
  • Check for linter errors (in PR)
  • Test basic user operations (on DFX services)
    • Login/logout
    • Buy/sell payment request
    • KYC page

Post-Release

  • Test basic user operations
  • Monitor application insights log

Copy link

@theresia-web theresia-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Code review durchgeführt. Die Änderungen sind korrekt implementiert:

  • ✅ Wallet-spezifische Registrierungsprüfung statt Account-weit
  • ✅ Case-insensitive Wallet-Vergleich
  • ✅ Null-Safety implementiert
  • ✅ DRY: Methode wird konsistent an allen 3 Stellen verwendet

Keine Security-Issues gefunden.

@xlamn xlamn merged commit 9c67c03 into develop Jan 29, 2026
7 checks passed
@xlamn xlamn deleted the fix/require-registration-for-wallet branch January 29, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants