Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 26, 2026

The eslint rule dnn-modal-no-background-dismiss was checking for backgroundDismiss instead of the correct property name backdropDismiss, causing it to never trigger on the deprecated property.

Changes

  • Rule implementation: Updated attribute lookup from backgroundDismiss to backdropDismiss and autofix suggestion from preventBackgroundDismiss to preventBackdropDismiss
  • Tests: Corrected test cases to use proper property names
  • Documentation: Fixed examples to reference correct property names

Example

The rule now correctly detects:

// Before: rule didn't trigger (wrong attribute name)
<dnn-modal backdropDismiss={false}>

// After: rule triggers and autofixes to
<dnn-modal preventBackdropDismiss>

The correct property names match the actual component implementation in dnn-modal.tsx which defines backdropDismiss and preventBackdropDismiss.

Original prompt

This section details on the original issue you should resolve

<issue_title>eslint plugin typo in backgroundDismiss</issue_title>
<issue_description>The eslint rule/autofix for backdropDismiss is wrong and has backgroundDismiss instead of backdropDismiss</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: valadas <6371568+valadas@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix eslint plugin typo in backgroundDismiss Fix eslint rule typo: backgroundDismiss → backdropDismiss Jan 26, 2026
Copilot AI requested a review from valadas January 26, 2026 20:47
@valadas valadas added this to the 0.27.8 milestone Jan 26, 2026
@valadas valadas changed the base branch from develop to release/0.27.8 January 26, 2026 20:56
@valadas valadas marked this pull request as ready for review January 26, 2026 20:57
@valadas valadas added the bug Something isn't working label Jan 26, 2026
@valadas valadas merged commit 73a03c6 into release/0.27.8 Jan 26, 2026
2 checks passed
@valadas valadas deleted the copilot/fix-eslint-plugin-typo branch January 26, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eslint plugin typo in backgroundDismiss

2 participants