Skip to content

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Jan 20, 2026

Description

Process_tags will be added to remote config in a follow-up PR.
To test the feature we need to do something like that:

try {
    $request = $rr->waitForRequest(function($req) {
        return strpos($req["uri"], '/v0.7/config') !== false;
    });
    $body = json_decode($request["body"], true);
} catch (Exception $e) {
    echo "ERROR: No RC request found\n";
    exit(1);
}

if (!isset($body["client"]["client_tracer"]["process_tags"])) {
    echo "ERROR: Missing 'process_tags' field\n";
    exit(1);
}

echo $body["client"]["client_tracer"]["process_tags"];
del_rc_file($path);

However, until this PR, RC requests were not stored which was making a test like that impossible.
This PR therefore stores the RC requests so we can retrieve them in tests.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-official
Copy link

datadog-official bot commented Jan 20, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1024 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 696f744000000000ea80d900cf0e9dad
tid: 696f744000000000
hexProcessTraceId: ea80d900cf0e9dad
hexProcessSpanId: 417bee7aed08cc56
processTraceId: 16897744399391169965
processSpanId: 4718627246330924118

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9295eff | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants