Adding di.cache module #76
Conversation
di/cache/cache.q
Outdated
| / Return the result | ||
| res}; | ||
|
|
||
| // Drop some ids from the cache |
There was a problem hiding this comment.
comments from here onwards use // instead of /
There was a problem hiding this comment.
rest of file has been fixed but this line still has //
di/cache/cache.q
Outdated
| / function to change default max individual value | ||
| setmaxindiv:{.z.m.maxindividual:x} | ||
|
|
||
| / function to change default max size value | ||
| setmaxsize:{.z.m.maxsize:x} |
There was a problem hiding this comment.
we need to do similar to line 19 in both of these functions to make sure maxindividual is never larger than maxsize
There was a problem hiding this comment.
If we are setting maxsize and maxindividual here and then line 19 runs after, would that not do this already?
There was a problem hiding this comment.
during first load, yes, but the point of these functions is that user can set the variables after inital load, and line 19 won't run again in those instances
There was a problem hiding this comment.
Ah I see, will update that now.
di/cache/cache.q
Outdated
| / Return the result | ||
| res}; | ||
|
|
||
| // Drop some ids from the cache |
There was a problem hiding this comment.
rest of file has been fixed but this line still has //
There was a problem hiding this comment.
we should probably have tests for setmaxinidiv and setmaxsize, including validating that the max sizes are respected by execute
Commiting code from Adam Beck and Lewis Cooley