Skip to content

Conversation

@tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Dec 18, 2025

Using the find_device method instead of looking devices up in the map of
devices directly means child devices can be found, eg 'stage.x' could be
a valid device but isn't in the devices map in its own right.

There is still a bit of weirdness as querying /devices/stage.x will return a
DeviceModel with a name of stage-x but querying for stage-x will
fail with a 404.

Relates to #903 and #1137.

@tpoliaw tpoliaw requested a review from a team as a code owner December 18, 2025 12:47
@tpoliaw tpoliaw requested a review from abbiemery December 18, 2025 12:48
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (d3596c5) to head (763a49c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1315   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files          42       42           
  Lines        2762     2764    +2     
=======================================
+ Hits         2624     2626    +2     
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw tpoliaw changed the title Use find_device from device endpoint fix: Use find_device from device endpoint Jan 14, 2026
Copy link
Contributor

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I understand the problem I think this is a valid improvement for now. It is worth us figuring out what approach we want to take re finding and returning devices going forward.

Using the find_device method instead of looking devices up in the map of
devices directly means child devices can be found, eg 'stage.x' could be
a valid device but isn't in the devices map in its own right.
@tpoliaw tpoliaw merged commit 2ee30ca into main Jan 20, 2026
18 checks passed
@tpoliaw tpoliaw deleted the find-device branch January 20, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants