Paged app and repository list #1184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why does repo list need paging? Its really snappy anyways. Also I fail to understand a the reason of introducing paging here, it does not feel slow to me. Can you explain your reasoning please |
Contributor
Author
|
You’re right — paging is not strictly required for the repo list itself, since the number of repositories is typically small compared to the app list. The main motivation for introducing paging here was consistency: having both lists follow the same loading and data-flow pattern. |
Signed-off-by: András Oravecz <info@oandras.hu>
oraveczandrew
force-pushed
the
paged-app-and-repo-list
branch
from
c024dac to
7757789
Compare
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
… fragments and viewModels on backpress Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the Paging 3 library, database access and JSON parsing are offloaded to background IO threads, improving performance and responsiveness.