Skip to content

Conversation

@vLuckyyy
Copy link
Member

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @vLuckyyy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces robust handling for snapshot versions within the update checking system. It ensures that stable builds are not offered updates to development snapshots and refines the Maven publishing configuration to be more secure and flexible. The changes improve the reliability and clarity of version management, particularly for projects utilizing snapshot releases.

Highlights

  • Snapshot Version Tracking: The Version class now includes a new isSnapshot() method, allowing for explicit identification of snapshot versions within the updater logic.
  • Intelligent Modrinth Update Filtering: The ModrinthUpdateChecker has been enhanced to filter out snapshot releases when checking for updates for a stable current version, ensuring that users are only prompted for stable updates and not development builds.
  • Conditional Maven Publishing Credentials: The commons-publish.gradle.kts script now conditionally applies Maven repository credentials only if the ETERNAL_CODE_MAVEN_USERNAME and ETERNAL_CODE_MAVEN_PASSWORD environment variables are set, preventing publishing attempts without proper authentication.
  • Improved Example Checker: The example application (ExampleChecker.java) has been updated to demonstrate update checks for both stable and snapshot versions, providing clearer usage examples and test cases for the new snapshot handling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@vLuckyyy vLuckyyy changed the title Add snapshot tracking to updater GH-73 Add snapshot tracking to updater Jan 17, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for handling snapshot versions in the update checker. The main logic change is in ModrinthUpdateChecker to filter out snapshot releases when the current version is not a snapshot. The Gradle publishing script is also updated to handle credentials more safely.

The changes are well-implemented. I've added one suggestion to improve the robustness of the version parsing in ModrinthUpdateChecker to prevent potential crashes when encountering unparsable version strings from the Modrinth API.

@vLuckyyy vLuckyyy merged commit a7d4b7c into master Jan 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants