feat: clarify File derivatives and add illegal char guideline #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen-sz <owen@fyralabs.com>
Deploying devdocs with
|
| Latest commit: |
f7bc35a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad11f11d.devdocs-next.pages.dev |
| Branch Preview URL: | https://owen-guidelines-and-stuff.devdocs-next.pages.dev |
madonuko
reviewed
Jan 23, 2026
|
|
||
| ```rpmspec | ||
| %global ver UPSTREAM-VERSION | ||
| %global sanitized_ver %(echo %{ver} | sed 's/-//g') |
Member
Author
There was a problem hiding this comment.
Oh like adding a . instead of a /? I copied this from how most our current specs do it... but the . does make more sense
Collaborator
There was a problem hiding this comment.
Personally, I would change UPSTREAM-VERSION to an example involving a date for something more real world.
Member
There was a problem hiding this comment.
actually why do we need this section? even if so this should be in fedora not us?
Signed-off-by: Owen-sz <owen@fyralabs.com>
Owen-sz
changed the title
GildedRoach
approved these changes
Jan 24, 2026
madonuko
reviewed
Jan 24, 2026
| # ╰─ mado: personally never seen this used | ||
| %config(…) … | ||
| # ╰─ exhaustive list: | ||
| # - config(missingok) |
Collaborator
There was a problem hiding this comment.
Oh wow this did not show up as missing on mobile LMAO
| # ╰─ store the file into %{_docdir} | ||
| %docdir | ||
| # ╰─ mado: personally never seen this used | ||
| # ╰─ Define a directory as a documentation-only directory. Can be used when a package defines its own documentation folder and contains a large number of doc files. |
|
|
||
| ```rpmspec | ||
| %global ver UPSTREAM-VERSION | ||
| %global sanitized_ver %(echo %{ver} | sed 's/-//g') |
Member
There was a problem hiding this comment.
actually why do we need this section? even if so this should be in fedora not us?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.