refactor: Enable the subsolver(s) in a sequentially coupled solver to be sequentially coupled too #3946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a multiphysics solver sequentially couples the subsolver A and subsolver B, the current architecture of
CoupledSolverdoesn't allow the subsolver A or B to be sequentially coupled. It is mainly because of limitations in two places:setupSystemfor subsolver(s). Now, there is nosetupSystemwell defined for the sequentially coupled (sub)solver.The fix is to check if the subsolver is sequentially coupled as well. If so, we loop on the sub-subsolvers (if it is fully implicit) to set up the system.
nonlinearImplicitStepfor subsolver(s). Now, there is nononlinearImplicitStepwell defined for the sequentially coupled (sub)solver.The fix is re-format the
sequentiallyCoupledSolverStepand add a method calledsequentiallyNonlinearImplicitStep, which stores the original sequential loop codes. Also, we re-define thenonlinearImplicitStepfor the coupled solver, and check if the subsolver is sequentially coupled. If so, we loop on the sub-subsolvers (if it is fully implicit) to performnonlinearImplicitStep.