fix: make sure we don't have left over users and channels #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaljam
requested review from
10printhello,
slavabobik and
totalimmersion
as code owners
totalimmersion
previously approved these changes
Apr 8, 2025
slavabobik
reviewed
Apr 9, 2025
|
|
||
| def delete(self) -> StreamResponse: | ||
| return self.client.delete(self.url) | ||
| def delete(self, hard: bool = False) -> StreamResponse: |
Contributor
There was a problem hiding this comment.
Is this a breaking change, or you can call delete without passing the hard flag?
Contributor
Author
There was a problem hiding this comment.
It is not a breaking change. You can. It has a default.
slavabobik
previously approved these changes
Apr 9, 2025
totalimmersion
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request