Skip to content

Conversation

@adityaalifn
Copy link
Contributor

@adityaalifn adityaalifn commented Apr 11, 2025

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

We added support of filter and sort parameter in QueryThreads endpoint. This MR adds the query_thread functionality to be used for client.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

black

[black] reported by reviewdog 🐶

def test_query_threads_with_options(self, client: StreamChat, channel, random_user: Dict):
parent_message = channel.send_message({"text": "Parent message"}, random_user["id"])


[black] reported by reviewdog 🐶

{"text": f"Thread message {i}", "parent_id": parent_message["message"]["id"]},
random_user["id"]


[black] reported by reviewdog 🐶


[black] reported by reviewdog 🐶


[black] reported by reviewdog 🐶

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

flake8

⚠️ [flake8] <293> reported by reviewdog 🐶
blank line contains whitespace


⚠️ [flake8] <293> reported by reviewdog 🐶
blank line contains whitespace


⚠️ [flake8] <293> reported by reviewdog 🐶
blank line contains whitespace


⚠️ [flake8] <291> reported by reviewdog 🐶
trailing whitespace

# So we just check that we got some threads back


⚠️ [flake8] <292> reported by reviewdog 🐶
no newline at end of file

# So we just check that we got some threads back


📝 [flake8] <3> reported by reviewdog 🐶
isort expected 1 blank line in imports, found 0


📝 [flake8] <5> reported by reviewdog 🐶
isort found an unexpected missing import


📝 [flake8] <1> reported by reviewdog 🐶
isort found an import in the wrong position


[flake8] <401> reported by reviewdog 🐶
'typing.Any' imported but unused


📝 [flake8] <3> reported by reviewdog 🐶
isort expected 1 blank line in imports, found 0


🚫 [flake8] <302> reported by reviewdog 🐶
expected 2 blank lines, found 1


⚠️ [flake8] <293> reported by reviewdog 🐶
blank line contains whitespace


⚠️ [flake8] <293> reported by reviewdog 🐶
blank line contains whitespace


⚠️ [flake8] <293> reported by reviewdog 🐶
blank line contains whitespace


⚠️ [flake8] <293> reported by reviewdog 🐶
blank line contains whitespace


⚠️ [flake8] <293> reported by reviewdog 🐶
blank line contains whitespace

@adityaalifn adityaalifn changed the title Add query threads [CHA-794] Add query threads Apr 11, 2025
@adityaalifn adityaalifn marked this pull request as ready for review April 11, 2025 11:20
adityaalifn and others added 2 commits April 11, 2025 13:22
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@adityaalifn adityaalifn merged commit c2b42c5 into master Apr 11, 2025
6 checks passed
@adityaalifn adityaalifn deleted the add-query-threads branch April 11, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants