-
Notifications
You must be signed in to change notification settings - Fork 21
[CHA-794] Add query threads #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
black
[black] reported by reviewdog 🐶
stream-chat-python/stream_chat/tests/test_query_threads.py
Lines 34 to 35 in 7bbc05c
| def test_query_threads_with_options(self, client: StreamChat, channel, random_user: Dict): | |
| parent_message = channel.send_message({"text": "Parent message"}, random_user["id"]) |
[black] reported by reviewdog 🐶
stream-chat-python/stream_chat/tests/test_query_threads.py
Lines 39 to 40 in 7bbc05c
| {"text": f"Thread message {i}", "parent_id": parent_message["message"]["id"]}, | |
| random_user["id"] |
[black] reported by reviewdog 🐶
[black] reported by reviewdog 🐶
| user_id=random_user["id"] |
[black] reported by reviewdog 🐶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
flake8
blank line contains whitespace
blank line contains whitespace
blank line contains whitespace
trailing whitespace
| # So we just check that we got some threads back |
no newline at end of file
| # So we just check that we got some threads back |
📝 [flake8] <3> reported by reviewdog 🐶
isort expected 1 blank line in imports, found 0
| import pytest |
📝 [flake8] <5> reported by reviewdog 🐶
isort found an unexpected missing import
| import pytest |
📝 [flake8] <1> reported by reviewdog 🐶
isort found an import in the wrong position
| from typing import Dict, Any |
[flake8] <401> reported by reviewdog 🐶
'typing.Any' imported but unused
| from typing import Dict, Any |
📝 [flake8] <3> reported by reviewdog 🐶
isort expected 1 blank line in imports, found 0
🚫 [flake8] <302> reported by reviewdog 🐶
expected 2 blank lines, found 1
| @pytest.mark.incremental |
blank line contains whitespace
blank line contains whitespace
blank line contains whitespace
blank line contains whitespace
blank line contains whitespace
7bbc05c to
bb002bd
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Submit a pull request
CLA
Description of the pull request
We added support of filter and sort parameter in QueryThreads endpoint. This MR adds the query_thread functionality to be used for client.