Skip to content

Fix failing tests in query threads #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityaalifn merged 2 commits into from
Apr 29, 2025
Merged

Fix failing tests in query threads #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77a5c8f
Fix failing tests in query threads
adityaalifn Apr 29, 2025
5238ef4
Fix lint
adityaalifn Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions stream_chat/tests/async_chat/test_query_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ async def test_query_threads(
)

# Query threads with filter and sort
filter_conditions = {"parent_id": parent_message["message"]["id"]}
filter_conditions = {"parent_message_id": parent_message["message"]["id"]}
sort_conditions = [{"field": "created_at", "direction": -1}]

response = await client.query_threads(
Expand All @@ -43,23 +43,22 @@ async def test_query_threads(
async def test_query_threads_with_options(
self, client: StreamChatAsync, channel, random_user: Dict
):
# Create a thread with multiple messages
parent_message = await channel.send_message(
{"text": "Parent message"}, random_user["id"]
)
thread_messages = []

for i in range(3):
msg = await channel.send_message(
parent_msg = await channel.send_message(
{"text": f"Parent message {i}"}, random_user["id"]
)

await channel.send_message(
{
"text": f"Thread message {i}",
"parent_id": parent_message["message"]["id"],
"parent_id": parent_msg["message"]["id"],
},
random_user["id"],
)
thread_messages.append(msg)

# Query threads with limit and offset
filter_conditions = {"parent_id": parent_message["message"]["id"]}
filter_conditions = {"channel_cid": channel.cid}
sort_conditions = [{"field": "created_at", "direction": -1}]

response = await client.query_threads(
Expand Down
17 changes: 8 additions & 9 deletions stream_chat/tests/test_query_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def test_query_threads(self, client: StreamChat, channel, random_user: Dict):
random_user["id"],
)

filter_conditions = {"parent_id": parent_message["message"]["id"]}
filter_conditions = {"parent_message_id": parent_message["message"]["id"]}
sort_conditions = [{"field": "created_at", "direction": -1}]

response = client.query_threads(
Expand All @@ -36,21 +36,20 @@ def test_query_threads(self, client: StreamChat, channel, random_user: Dict):
def test_query_threads_with_options(
self, client: StreamChat, channel, random_user: Dict
):
parent_message = channel.send_message(
{"text": "Parent message"}, random_user["id"]
)
thread_messages = []
for i in range(3):
msg = channel.send_message(
parent_msg = channel.send_message(
{"text": f"Parent message {i}"}, random_user["id"]
)

channel.send_message(
{
"text": f"Thread message {i}",
"parent_id": parent_message["message"]["id"],
"parent_id": parent_msg["message"]["id"],
},
random_user["id"],
)
thread_messages.append(msg)

filter_conditions = {"parent_id": parent_message["message"]["id"]}
filter_conditions = {"channel_cid": channel.cid}
sort_conditions = [{"field": "created_at", "direction": -1}]

response = client.query_threads(
Expand Down