Handle NoSuchElementException exception when processing responses #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add getFetch method to ChromeDevToolsSession (cherry picked from commit dd38e73)
- Use `ChromeDevToolsClient.createBrowserContext()`` to create a Browser Context. - Attach to the target with `ChromeDevToolsBrowserContext.attach()` - There are two creation methods; one using host and port, the other directly using WebSocket address. (cherry picked from commit b35223e)
- Change groupId: uk.co.screamingfrog - Add Distribution Management to parent POM - Change artifactId (422: Unprocessable Entity) (cherry picked from commit cd02082)
- Handle response results with no return parameters - Catch NoSuchElementException and perform normal results extraction.
davidcockbill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a mechanism to bypass the use of the response results for results that have a single parameter.
This is broken for results that have no parameters.
This pull request catches the NoSuchElementException that is thrown in this case and unpacks an empty response.