Skip to content

Conversation

@davidcockbill
Copy link

  • Remove flattening of return types

This fix may be contentious as it changes the existing interface.

I have wondered about different ways of doing this, but the flattening method of removing intermediate response objects (whilst seeming to make sense for trivial stuff) does not hold up in a generic way for more complex returns; especially with multiple optional objects. I also find that it obscures the interface in the documentation.

To that end I have removed the flattening behaviour. So this means that statements like the following:

BrowserContextID browserContextId = getTarget().createBrowserContext();

Now need to add the object tree traversal:

BrowserContextID browserContextId = getTarget().createBrowserContext().browserContextId;

- Remove flattening of return types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant