-
Notifications
You must be signed in to change notification settings - Fork 0
fix: add CommonJS support #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 19 19
Branches 1 1
=========================================
Hits 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| options.jsx = 'automatic'; | ||
| }, | ||
| external: ['react', 'react-dom'], | ||
| noExternal: ['@hyphen/browser-sdk'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaredwray This allows usage without requiring users to install the browser package separately. Let me know if this is something you want to do.
|
@jaredwray we need to release |
|
@chrisllontop great. Go ahead |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)