Skip to content

Conversation

@jlubins
Copy link

@jlubins jlubins commented Dec 8, 2025

This PR addresses issues #119 and #154 where the core-dump-handler causes excessive bind mounts due to bidirectional mount propagation. When pods restart frequently (e.g., due to memory limits being set too low), this has potential to create thousands of duplicate bind mounts, leading to:

  • High I/O wait times
  • Node performance degradation
  • Potential node failures

The current implementation hardcodes mountPropagation: Bidirectional in the DaemonSet template. As noted in the Kubernetes documentation (see warning), bidirectional mount propagation can be dangerous and requires containers to properly clean up mounts on termination. Each pod restart doubles the number of mounts, quickly reaching system limits.

This PR makes mountPropagation configurable via Helm values and removes the bidirectional default. Users can now:

  • Use the safer default (no mount propagation specified)
  • Explicitly set bidirectional mode if needed for their use case
  • Choose other propagation modes as appropriate

@jlubins jlubins force-pushed the remove-bidirectional-mount-propagation-default branch from f745fcd to 0f815c8 Compare December 15, 2025 19:26
@jlubins jlubins force-pushed the remove-bidirectional-mount-propagation-default branch from 19a18a9 to 31cd748 Compare January 6, 2026 14:44
@jlubins
Copy link
Author

jlubins commented Jan 6, 2026

Hi @No9, when you have a chance, could I trouble you to review this PR? It has seemingly bitten several users in the past, and prevents me from safely using core-dump-handler in quite a few places.

@No9
Copy link
Collaborator

No9 commented Jan 7, 2026

@jlubins the lint is failing - can you update the PR to resolve this and I can merge

John Lubinski added 3 commits January 16, 2026 08:45
…fault

Signed-off-by: John Lubinski <john.lubinski@chicagotrading.com>
Signed-off-by: John Lubinski <john.lubinski@chicagotrading.com>
Signed-off-by: John Lubinski <john.lubinski@chicagotrading.com>
@jlubins jlubins force-pushed the remove-bidirectional-mount-propagation-default branch from 4f47fb7 to 6f5ffe7 Compare January 16, 2026 14:45
Signed-off-by: John Lubinski <john.lubinski@chicagotrading.com>
@jlubins
Copy link
Author

jlubins commented Jan 16, 2026

Hey @No9, apologies for the delay. Do I need approval to get the lint test to run again?

With my latest commit, I've fixed the Python version issue that was causing the workflow to fail:

Run actions/setup-python@v2
Version 3.7 was not found in the local cache
Error: Version 3.7 with arch x64 not found

I updated the version per the README docs for setup-python here. It looks like chart-testing-action accepts any latest minor version. I pinned to 3.13, but I can change it to '3.x' if you'd prefer the workflow to automatically use the latest Python 3 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants