Remove xml_parser_free from codebase (PHP 8.5 issue)
#10976
+11
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function has no effect. Prior to PHP 8.0.0, this function was used to close the resource.
mjansenDatabay
requested review from
GitHamo,
chfsx,
dsstrassner,
kergomard,
thibsy and
thojou
mjansenDatabay
changed the title
xml_parser_free from codebasexml_parser_free from codebase (PHP 8.5 issue)
kergomard
approved these changes
Jan 26, 2026
dsstrassner
approved these changes
Jan 26, 2026
Contributor
dsstrassner
left a comment
dsstrassner
left a comment
There was a problem hiding this comment.
I follow @kergomard. 🦘
sKarki999
approved these changes
Jan 26, 2026
Contributor
sKarki999
left a comment
sKarki999
left a comment
There was a problem hiding this comment.
Looks good. Thanks a lot, @mjansenDatabay :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function has no effect.
Prior to PHP 8.0.0, this function was used to
close the resource.