Skip to content

Add workflows for OSS projects #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PabloCollazoCollarte merged 40 commits into from
Mar 7, 2025
Merged

Add workflows for OSS projects #6

PabloCollazoCollarte merged 40 commits into from
Mar 7, 2025

Conversation

@PabloCollazoCollarte
Copy link

@PabloCollazoCollarte PabloCollazoCollarte commented Mar 5, 2025

Closes #5

jesusmpc and others added 2 commits February 28, 2025 12:35
@jesusmpc
Improve rendering handling (#2)
49720c7 
* chore: initial commit

* chore: fix linting issues

* chore: azure web pubsub initial support

* chore: fix tests

* chore: fix test

* chore: install missing jsdom dependency on react package
feat: added workflows
ef4a959
@PabloCollazoCollarte PabloCollazoCollarte self-assigned this Mar 5, 2025
@PabloCollazoCollarte PabloCollazoCollarte added the enhancement New feature or request label Mar 5, 2025
@InditexTech InditexTech deleted a comment from github-actions bot Mar 6, 2025
@PabloCollazoCollarte
Copy link
Author

PabloCollazoCollarte commented Mar 6, 2025

Hi @jesusmpc,
in this PR I am adding OSS workflows that were added in a OSS archetype that we have provided for the InditexTech org. As you can see, PR verify is failing due to some auth: https://github.com/InditexTech/weavejs/actions/runs/13694344728/job/38293297543?pr=6#step:8:31

This is because there are some internal references, for example, the ones that I have deleted in this commit. Also, some eslint configs should be updated, for example here, in order to work with the OSS workflows. I will set this task on hold until the code is refactored with this changes

@PabloCollazoCollarte PabloCollazoCollarte marked this pull request as ready for review March 6, 2025 12:38
@jesusmpc jesusmpc force-pushed the main branch 3 times, most recently from b0262d6 to e9b9424 Compare March 6, 2025 15:36
@github-actions
Copy link

github-actions bot commented Mar 7, 2025

🚀 Release Preview Success

You are going to release the version minor with the following changes:

0.1.0 - 2025-03-07

Added

  • #12 Automatic changelog generation
  • #10 Fix packages names to be on @InditexTech scope
  • #8 ESLint OSS rules
  • #2 Improve rendering handling

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-5 → main).

@PabloCollazoCollarte PabloCollazoCollarte added kind/feature and removed enhancement New feature or request labels Mar 7, 2025
@github-actions
Copy link

github-actions bot commented Mar 7, 2025

🚀 Release Preview Success

You are going to release the version minor with the following changes:

0.1.0 - 2025-03-07

Added

  • #12 Automatic changelog generation
  • #10 Fix packages names to be on @InditexTech scope
  • #8 ESLint OSS rules
  • #2 Improve rendering handling

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-5 → main).

@jesusmpc jesusmpc self-requested a review March 7, 2025 08:48
@jesusmpc jesusmpc self-requested a review March 7, 2025 08:50
danielfn
danielfn reviewed Mar 7, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Mar 7, 2025

🚀 Release Preview Success

You are going to release the version minor with the following changes:

0.1.0 - 2025-03-07

Added

  • #12 Automatic changelog generation
  • #10 Fix packages names to be on @InditexTech scope
  • #8 ESLint OSS rules
  • #2 Improve rendering handling

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-5 → main).

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

🚀 Release Preview Success

You are going to release the version minor with the following changes:

0.1.0 - 2025-03-07

Added

  • #5 Add workflows for OSS projects
  • #12 Automatic changelog generation
  • #10 Fix packages names to be on @InditexTech scope
  • #8 ESLint OSS rules
  • #2 Improve rendering handling

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-5 → main).

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

🚀 Release Preview Success

You are going to release the version minor with the following changes:

0.1.0 - 2025-03-07

Added

  • #5 Add workflows for OSS projects
  • #12 Automatic changelog generation
  • #10 Fix packages names to be on @InditexTech scope
  • #8 ESLint OSS rules
  • #2 Improve rendering handling

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-5 → main).

@PabloCollazoCollarte PabloCollazoCollarte merged commit a4e3346 into main Mar 7, 2025
5 of 6 checks passed
@PabloCollazoCollarte PabloCollazoCollarte deleted the feature/GH-5 branch March 7, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielfn danielfn danielfn left review comments

@jesusmpc jesusmpc jesusmpc approved these changes

Assignees

@PabloCollazoCollarte PabloCollazoCollarte

Labels

kind/feature release-type/minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add workflows for OSS projects

4 participants

@PabloCollazoCollarte @danielfn @jesusmpc